go: runtime: TestRuntimeLockMetricsAndProfile failures

#!watchflakes
post <- pkg == "runtime" && test == "TestRuntimeLockMetricsAndProfile"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestRuntimeLockMetricsAndProfile (0.03s)
    --- FAIL: TestRuntimeLockMetricsAndProfile/runtime.lock (0.02s)
        --- FAIL: TestRuntimeLockMetricsAndProfile/runtime.lock/sample-1 (0.01s)
            metrics_test.go:1048: lock contention growth in runtime/pprof's view  (0.006333s)
            metrics_test.go:1049: lock contention growth in runtime/metrics' view (0.006331s)
            metrics_test.go:1077: stack [runtime.unlock runtime_test.TestRuntimeLockMetricsAndProfile.func5.1 runtime_test.(*contentionWorker).run] has samples totaling n=99 value=6332772
            metrics_test.go:1156: mutex profile reported contention count different from the known true count (99 != 100)

— watchflakes

About this issue

Original URL
State: open
Created 7 months ago
Comments: 43 (17 by maintainers)

Commits related to this issue

runtime: test for contention in both semaphore paths Most contention on the runtime locks inside semaphores is observed in runtime.semrelease1, but it can also appear in runtime.semacquire1. When exa... — committed to golang/go by rhysh 7 months ago
runtime: skip TestRuntimeLockMetricsAndProfile for flakiness This test was added to check new mutex profile functionality. Specifically, it checks to make sure that the functionality behind GODEBUG=r... — committed to golang/go by mknyszek 6 months ago

Most upvoted comments

More of an explanation: these tests are checking behavior that’s behind a GODEBUG anyway. It’s fine if we just disable the tests, because even if something breaks between now and the next dev period (unlikely) it won’t affect the vast majority of users.

We won’t delete the tests because that functionality is going to be revisited for Go 1.23 anyway (by @rhysh I believe).

mknyszek on Dec 18, 2023