go: os/exec: tests break testing package if testlog file is not file descriptor 3

What version of Go are you using (`go version`)?

go version devel +2c0c68d621 Tue Mar 6 23:33:28 2018 +0000 linux/amd64

(This is the current git tip as I write this.)

What operating system and processor architecture are you using (`go env`)?

GOARCH="amd64"
GOOS="linux"

What did you do?

On one of my slower machines I’m getting frequent but not completely consistent test failures in the test phase of all.bash during testing of os.exec. This reproduces when testing just os/exec on its own:

$ go test os/exec
PASS
testing: can't write /tmp/go-build685356926/b001/testlog.txt: write /tmp/go-build685356926/b001/testlog.txt: broken pipe
FAIL    os/exec 0.400s

This failure happens on an i5-2500 (running Fedora 27). A Fedora 27 Ryzen 1800X machine consistently passes. This only started happening on recent versions of master (initially I wrote it off as flakiness on my machine).

It’s possible that this is related to #24050.

About this issue

Original URL
State: closed
Created 6 years ago
Reactions: 2
Comments: 23 (15 by maintainers)

Commits related to this issue

slapgrid: Do not leak file descriptors to subprocesses when running 'node software' Some context: I'm trying to build Go 1.10 under slapos and get failures like: ok os 0.782s PASS t... — committed to SlapOS/slapos.core by navytux 6 years ago

Most upvoted comments

I think this is basically the same as #35469 which we fixed. So let’s call this one fixed as well. Thanks.

ianlancetaylor on Dec 14, 2022

I can’t reproduce this with my original test (and I don’t think I’ve seen this in general for some time). I suspect that it’s gone, but maybe other people are still seeing this in their environments.

siebenmann on Dec 14, 2022