go: net/http: frequent failures in TestNoSniffExpectRequestBody_h2 since Oct. 28

--- FAIL: TestNoSniffExpectRequestBody_h2 (10.00s)
    clientserver_test.go:1316: unexpected Read call
2020/10/28 09:19:06 http: TLS handshake error from 127.0.0.1:33072: read tcp 127.0.0.1:33050->127.0.0.1:33072: use of closed network connection
FAIL
FAIL	net/http	24.279s

2020-10-28T14:25:56-b85c2dd/aix-ppc64 2020-10-28T13:46:11-a0a4439/solaris-amd64-oraclerel 2020-10-28T13:25:44-72dec90/aix-ppc64 2020-10-28T04:20:39-02335cf/aix-ppc64 2020-10-28T01:22:47-2414e1f/aix-ppc64 2020-10-28T01:18:38-7be9158/solaris-amd64-oraclerel

Marking as release-blocker because this appears to be a regression in 1.16.

The failures so far are on somewhat esoteric builders, but those are also some of our slowest builders — this could be a timing bug that just happens to reproduce more easily on them.

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 15 (15 by maintainers)

Most upvoted comments

I don’t see any occurrences of this test failure since October 30, 2020, so closing.

ianlancetaylor on Jan 7, 2021

That usage is fine. The Stop method will return true if the function has not yet run. After calling Stop, it’s fine to call Reset to set a new time.

ianlancetaylor on Nov 3, 2020

I’m pretty certain this has been fixed, but I haven’t managed to bisect down to the exact point of the fix yet. It reproduces on these builders at the previously-failing commits with -count 100, but not at head.

neild on Nov 2, 2020