go: [go1.8beta2] Investigating bad bad break in docker test suite
What version of Go are you using (go version
)?
1.8beta2
What operating system and processor architecture are you using (go env
)?
linux/amd64
What did you do?
Testing 1.8beta on docker’s test suite
What did you expect to see?
Tests actually run
What did you see instead?
All of our integration tests are erroring.
This only happens with beta2. Beta1 had a couple of failures (1 which was fixed). Beta2 has broken our entire integration suite. We are still investigating the potential cause, but are turning up short at the moment as there’s not much to go on.
I have not reproduced any issue with manual testing, but using the test suite any and every test errors during cleanup with a response from the docker daemon of page not found
About this issue
- Original URL
- State: closed
- Created 8 years ago
- Comments: 22 (13 by maintainers)
For the record, 7db996ee77b20b68ee583c65d59be1d81cef9090 (CL 29852) changed
shouldRedirectPost
from only redirecting StatusFound, StatusSeeOther (302 & 303) to also including StatusMovedPermanently (301) in the new funcredirectBehavior
, to fix #9348 and other bugs.https://tools.ietf.org/html/rfc7231#section-6.4.2 says:
And from the discussion in #9348, it seems the new behavior is the desired and correct behavior.
This program changed from Go 1.7 to Go 1.8 and is (I believe) the source of docker’s problems.
Before the POST got a redirect and returned that error. Now it follows the redirect, translates to GET, and gets 404. I guess Docker was swallowing the 301 but is now choking on the 404.