go: cmd/vet/all: build failures affecting misc-vet-vetall

What version of Go are you using (go version)?

go version devel +0fe1986a72 Thu Mar 21 01:35:21 2019 +0000 linux/arm64

Does this issue reproduce with the latest release?

no

What operating system and processor architecture are you using (go env)?

GOARCH=“arm64” GOBIN=“” GOCACHE=“/home//.cache/go-build" GOEXE=“” GOFLAGS=“” GOHOSTARCH=“arm64” GOHOSTOS=“linux” GOOS=“linux” GOPATH="/home//go” GOPROXY=“” GORACE=“” GOROOT=“/home//go-master” GOTMPDIR=“” GOTOOLDIR=“/home//go-master/pkg/tool/linux_arm64” GCCGO=“gccgo” CC=“gcc” CXX=“g++” CGO_ENABLED=“1” GOMOD=“/home//go-master/src/go.mod” CGO_CFLAGS=“-g -O2” CGO_CPPFLAGS=“” CGO_CXXFLAGS=“-g -O2” CGO_FFLAGS=“-g -O2” CGO_LDFLAGS=“-g -O2” PKG_CONFIG=“pkg-config” GOGCCFLAGS=“-fPIC -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build580593418=/tmp/go-build -gno-record-gcc-switches”

The problem also occurs on amd64.

What did you do?

GO_BUILDER_NAME=*-vetall …/bin/go tool dist test -run arm64$

What did you expect to see?

Testing packages.

ok cmd/internal/obj/arm64 0.056s

ALL TESTS PASSED (some were excluded)

What did you see instead?

cmd/vet/all

go run main.go -p darwin/arm64 encoding/xml/marshal.go:104: method MarshalXML(e *xml.Encoder, start xml.StartElement) error should have signature MarshalXML(*xml.Encoder, xml.StartElement) error encoding/xml/read.go:175: method UnmarshalXML(d *xml.Decoder, start xml.StartElement) error should have signature UnmarshalXML(*xml.Decoder, xml.StartElement) error encoding/xml/marshal_test.go:317: method MarshalXML(e *xml.Encoder, start xml.StartElement) error should have signature MarshalXML(*xml.Encoder, xml.StartElement) error encoding/xml/read_test.go:630: method UnmarshalXML(d *xml.Decoder, start xml.StartElement) error should have signature UnmarshalXML(*xml.Decoder, xml.StartElement) error encoding/xml/xml_test.go:887: method UnmarshalXML(*xml.Decoder, xml.StartElement) error should have signature UnmarshalXML(*xml.Decoder, xml.StartElement) error exit status 1 2019/03/21 06:14:58 Failed: exit status 1 go run main.go -p android/arm64 encoding/xml/marshal.go:104: method MarshalXML(e *xml.Encoder, start xml.StartElement) error should have signature MarshalXML(*xml.Encoder, xml.StartElement) error encoding/xml/read.go:175: method UnmarshalXML(d *xml.Decoder, start xml.StartElement) error should have signature UnmarshalXML(*xml.Decoder, xml.StartElement) error encoding/xml/marshal_test.go:317: method MarshalXML(e *xml.Encoder, start xml.StartElement) error should have signature MarshalXML(*xml.Encoder, xml.StartElement) error encoding/xml/read_test.go:630: method UnmarshalXML(d *xml.Decoder, start xml.StartElement) error should have signature UnmarshalXML(*xml.Decoder, xml.StartElement) error encoding/xml/xml_test.go:887: method UnmarshalXML(*xml.Decoder, xml.StartElement) error should have signature UnmarshalXML(*xml.Decoder, xml.StartElement) error exit status 1 2019/03/21 06:14:59 Failed: exit status 1 go run main.go -p linux/arm64 encoding/xml/marshal.go:104: method MarshalXML(e *xml.Encoder, start xml.StartElement) error should have signature MarshalXML(*xml.Encoder, xml.StartElement) error encoding/xml/read.go:175: method UnmarshalXML(d *xml.Decoder, start xml.StartElement) error should have signature UnmarshalXML(*xml.Decoder, xml.StartElement) error encoding/xml/marshal_test.go:317: method MarshalXML(e *xml.Encoder, start xml.StartElement) error should have signature MarshalXML(*xml.Encoder, xml.StartElement) error encoding/xml/read_test.go:630: method UnmarshalXML(d *xml.Decoder, start xml.StartElement) error should have signature UnmarshalXML(*xml.Decoder, xml.StartElement) error encoding/xml/xml_test.go:887: method UnmarshalXML(*xml.Decoder, xml.StartElement) error should have signature UnmarshalXML(*xml.Decoder, xml.StartElement) error exit status 1 2019/03/21 06:14:59 Failed: exit status 1 2019/03/21 06:15:00 FAILED