go: cmd/compile: "UNREVIEWED" headers scattered around the tree

A bunch of files in the tree start:

// UNREVIEWED

I assume this is left over from generics work. Can those all be removed now?

cc @ianlancetaylor @griesemer @mdempsky

About this issue

Original URL
State: closed
Created 3 years ago
Comments: 15 (11 by maintainers)

Commits related to this issue

internal/pkgbits: finish documentation This CL adds documentation for all exported pkgbits APIs, and removes its UNREVIEWED comments. Updates #48194. Change-Id: Ifff548cd9f31a5c5cc5f400a6dae5c98c46... — committed to golang/go by mdempsky 2 years ago
[dev.unified] cmd/compile: more Unified IR docs and review This adds more documentation throughout the core Unified IR logic and removes their UNREVIEWED notices. Updates #48194. Change-Id: Iddd30e... — committed to golang/go by mdempsky 2 years ago
[dev.unified] cmd/compile: more Unified IR docs and review This adds more documentation throughout the core Unified IR logic and removes their UNREVIEWED notices. Updates #48194. Change-Id: Iddd30e... — committed to jproberts/go by mdempsky 2 years ago

Most upvoted comments

Yeah, all of those files are only used for GOEXPERIMENT=unified, which we’ve decided to defer to Go 1.19.

mdempsky on Sep 22, 2021

Files marked as //UNREVIEWED need to be reviewed explicitly. I see (under src):

./cmd/compile/internal/importer/testdata/exports.go:// UNREVIEWED
./cmd/compile/internal/importer/testdata/issue25301.go:// UNREVIEWED
./cmd/compile/internal/importer/testdata/issue25596.go:// UNREVIEWED
./cmd/compile/internal/importer/testdata/versions/test.go:// UNREVIEWED
./cmd/compile/internal/importer/testdata/issue20046.go:// UNREVIEWED
./cmd/compile/internal/importer/testdata/a.go:// UNREVIEWED
./cmd/compile/internal/importer/testdata/b.go:// UNREVIEWED
./cmd/compile/internal/importer/testdata/p.go:// UNREVIEWED
./cmd/compile/internal/importer/testdata/issue15920.go:// UNREVIEWED
./cmd/compile/internal/noder/unified.go:// UNREVIEWED
./cmd/compile/internal/noder/decoder.go:// UNREVIEWED
./cmd/compile/internal/noder/sync.go:// UNREVIEWED
./cmd/compile/internal/noder/encoder.go:// UNREVIEWED
./cmd/compile/internal/noder/reader2.go:// UNREVIEWED
./cmd/compile/internal/noder/quirks.go:// UNREVIEWED
./cmd/compile/internal/noder/codes.go:// UNREVIEWED
./cmd/compile/internal/noder/writer.go:// UNREVIEWED
./cmd/compile/internal/noder/reloc.go:// UNREVIEWED
./cmd/compile/internal/noder/linker.go:// UNREVIEWED
./cmd/compile/internal/noder/reader.go:// UNREVIEWED

The importer test files should match the corresponding test files elsewhere and should be straight-forward. We review them by comparing them against existing reviewed files and pointing out the differences, if any.

The noder files are related to @mdempsky 's work on the unified IR and need to be reviewed in full. This is planned to happen by the end of October (before the freeze).

griesemer on Sep 4, 2021