GodotSteam: Crash when game is not owned on logged in account

Yeah, I can recreate it too if I used a different app ID.

Is the implication that if the game isn’t installed it will crash? Otherwise I can’t imagine running into a problem where one is running their game with anothers app ID, and where a player is somehow executing a copy of the game without having installed it.

The problem is because SteamUser() is returning a null pointer. Doesn’t seem to be documented, but a lot of the other API methods seem to do this too.

Not sure how you’d want to handle it, check if SteamUser() is null first, and throw an error “Invalid app ID or app not installed”?

That’s fuzzy as well, it’s not clear if these are the only condition where it fails and returns null, can’t inspect their code. I presume the wrong app ID just leads to the same problem, you don’t have it installed.

Either way it’s probably fixed in a few lines.

I did notice this in the header btw just now getAPICallFailureReason() It returns a string, curious if that gives the reason for the init failure after it was attempted.

Yeah, I was wondering too, I was expecting the API would’ve had something to simply launch steam. (Kind of thought steam init would do that at first glance.) The restart app if necessary is the closest thing, but that won’t work with running from the editor. If I recall correctly, it will restart to the build that is downloaded to your steam apps directory.

No big deal though, this is just for editor testing side of things only, so a constant is fine since we control where steam is installed on our end. The other steam startup logic works fine for release builds.

If there is a way to reliably get the app path from all the supported OSes, it might be a nice feature to have in some situations.

It wouldn’t be too much more than the example project. Might add a timeout or handle certain errors depending on what comes up.

extends Node2D

const STEAM_PATH = "C:\\Program Files (x86)\\Steam\\Steam.exe"

func _ready() -> void:

	var pid = -1
	var result = Steam.steamInit()


	while(result.status != Steam.RESULT_OK):
		
		if(pid == -1):

			print("Starting Steam.")
			pid = OS.execute(STEAM_PATH, PoolStringArray(), false)
		
		yield(get_tree().create_timer(1.0), "timeout")		
		result = Steam.steamInit()

I think only when multiple people use Steam on the same PC, that’s how we came across it.

Ah, interesting, hadn’t thought about shared storage with multiple users. It would make sense for them to leave the files of un-owned games. Yeah, it would be good to handle that situation gracefully with some feedback.

This also fixes this issues: https://github.com/Gramps/GodotSteam/issues/127

So another plus is that I can now write a script to attempt to launch and await for Steam to open when launching from the editor.

Yep, works! Thanks so much! 😄

Oh yeah, this isn’t a huge issue probably (I think only when multiple people use Steam on the same PC, that’s how we came across it), but since it was so consistent I though it might be an easy fix 😃 Might save some cryptic support mails in the future, haha.

Hmm, that’s pretty interesting and a fantastic lead, sir! Yeah, the situations where this arises shouldn’t be common but still should be fixed.

I’ll mess around with this and get a patch in by the weekend. Thank you for this information!

UPDATE: Huh, I get a totally different error before it spits up the backtrace portion.

I’m compiling from scratch, with msvc, using these options: scons -j6 platform=windows target=release_debug use_lto=yes disable_3d=yes. I just tried it with the pre-compiled build, but it had the same issue (although I now got the second traceback, with all the <couldn't map PC to fn name> lines, instead of the first traceback?).

I do have an steam_appid.txt in the editor directory yes 😃 Everything works fine and Steam recognizes the game if I start the game from the editor with an account that does own the (unreleased) game. The crash specifically and reliably occurs for me if I’m logged into a Steam account that doesn’t own the valid, unreleased appid.