godot: TypeError in methods.py when running initial build with vsproj=yes (SCons 4.5.0 regression)

Godot version

4.0-stable, 3.5.2-stable

System information

Windows 10

Issue description

My first time building Godot ever, I compiled 4.0 with scons platform=windows and everything ran perfectly fine, but once I realized I needed to specify something else to get the visual studio solution, I compiled it again with scons platform=windows vsproj=yes and received the following error:

Found MSVC version 14.3, arch x86_64
Building for platform "windows", architecture "x86_64", target "editor".
TypeError: can only concatenate deque (not "list") to deque:
  File "\godot\SConstruct", line 927:
    methods.generate_vs_project(env, GetOption("num_jobs"), env["vsproj_name"])
  File "\godot\methods.py", line 860:
    module_configs = ModuleConfigs()
  File "\godot\methods.py", line 764:
    self.add_mode()  # default
  File "\godot\methods.py", line 787:
    self.arg_dict["cppdefines"] += ModuleConfigs.for_every_variant(env["CPPDEFINES"] + defines)

I then tried to figure out if it was just a 4.0 issue, so I cloned a fresh 3.5.2 repo and tried compiling with vsproj=yes and yet again was met with the same error. I also tried downgrading from current python version down to 3.6.1, but the error remained. Prior to posting this, I noticed this issue, which seems like it could be related, but being unsure since it was slightly different, I’m proceeding here.

I ended up “solving” the issue by adding from collections import deque to the start of methods.py and changing line 773 from defines = [] to defines = deque(). It allowed the build to proceed, created the visual studio solution, and doesn’t appear to have created any issues. However, I do not know enough about the build process or the project in general to truly know whether my “fix” creates any negative side effects, so hopefully someone more knowledgeable than me can chime in on that.

Steps to reproduce

1. Clone a fresh repo from either 4.0-stable or 3.5.2-stable (possibly even older versions as well).
2. Build on windows 10 with scons platform=windows vsproj=yes
3. Should give you the error.

Minimal reproduction project

N/A