godot: Statically linked mono on Windows - external profiler doesn't work

Godot version: 3.2

OS/device including version: Windows 10

Issue description: When following steps in godotengine/godot#34382 JetBrains dotTrace or JetBrains Rider show “Unsupported Mono version” It happens only on Windows with official Godot build, however with locally compiled Godot build with dynamically liked mono profiler works fine.

JetBrains engineers think that when mono is statically linked, its exports are not inherited.

JetBrains profiler dll loaded in Godot process is looking for mono api function and fails.

auto lib_handle = LoadLibrary("godot_exe_name");
auto func = GetProcAddress(lib_handle, "some_mono_function"); // this call fails

Example of the function: MONO_API MonoProfilerHandle mono_profiler_create (MonoProfiler *prof);

This happens only on Windows because mono on Windows works differently, as mono documentations says that for windows each function should be marked for export. https://www.mono-project.com/docs/advanced/embedding/#windows-considerations

About this issue

Original URL
State: open
Created 4 years ago
Reactions: 4
Comments: 17 (11 by maintainers)

Most upvoted comments

We are working on a solid fix, it requires changes in both Godot and JetBrains mono profiler.

van800 on Apr 14, 2020

If you link mono dynamically, it would solve the problem. Because profiler knows the exact name of the library, which contains mono api functions and those functions are already exported. This option still seems to be safer than the new one below, which we are trying to implement.

To make it work with statically linked mono:

On Godot side all mono api functions, required by the profiler, have to be exported again. Example: https://github.com/CRYTEK/CRYENGINE/compare/release...van800:mono-profiler#diff-6bc0fb18f4886d5b565152a0758f830eR1-R76
On profiler side we have to try all assemblies in the process and find the one with those exports.

van800 on Apr 15, 2020

This is absolutely not a good place to discuss the mentioned issues. I propose we move to a new issue in https://youtrack.jetbrains.com/issues/RIDER Please create one directly from Rider with Help - Report a Bug. Thanks!

van800 on May 27, 2022

Searching mono library in a process is not a problem itself because official mono library name could be changed by Mono developers as well. The only significant problem here is inability to load mono exported functions from statically linked mono library. And as @neikeq noticed having fixed list of symbols on Godot side we should maintain it all the time. Even though adding new symbols seems uncommon we might need it to implement some new features. Thus it would be much better for us to work with dynamically linked mono.

evgn on Apr 16, 2020

@MrZak-dev only known workaround is to compile godot locally.

van800 on Mar 6, 2020