godot: Nodes shouldn't be added to 'idle_process' group

You know @akien-mga after thinking about it a bit more. I kind of prefer getting the info from the groups. Here’s why. Say you have multiple resources, some start with ‘enemy’, some start with ‘this’ some with ‘that’ etc. You get the idea. If you spread all over the place code like:

assert(...is_inside_group('constant'))
etc.

You still have to do massive refactoring. Alright, so don’t use hard coded string values, let’s instead use a class variable to store these things… like an array with a specific order. But wait, isn’t that what groups should do in the first place?! So I noticed that the groups mechanism forces an alphabetical order (except for the internal states for some reason, which I think can either go at beginning or at end of the array).

So in the end of it all I think we should have get_groups(internal=true,false) as mentioned but also have order in the group array so that would mean enhancing the group panel to allow ordering of groups. They’re arrays after all, not sets or maps or other things and arrays have order to them. Also allow editing in the panel, as of now you can only remove and add groups. So then there would be no problem with get_groups()[0, 1, 2, 3.. etc.] as the order would be guaranteed to be the one you set.

It’s bad practice (IMO) because if you decide to add those enemies to a new “flying” group for flying enemies, your code might break. Writing code that assumes that you’ll hopefully use the right group name to match your node names is hazardous. It’s IMO much better to write one more line and be future proof:

assert(that_node.is_inside_group("enemy"))
var name = "enemy_%d" % randi()

than

# hope I won't break this by mistake in 6 months
var name = that_node.get_groups()[0] + "_%d" % randi()

And what’s wrong with get_groups(internal=true,false)?!

I haven’t said anything was wrong with it, I’m just raising questions as so far the discussion has only been about “whooo Godot is spilling its internals all over the floor” 😃

i don’t agree with this. it should rather just be made clear that _ is used for system groups.

On 30/01/2017, Răzvan Cosmin Rădulescu notifications@github.com wrote:

As long as the developer gets only the groups that he himself put in, doesn’t really matter how the internals of get_groups works. It’s a good idea to have get_groups remove everything starting with _ or maybe even __ in case someone decides for whatever reason to use a group name starting with _? Doing this wouldn’t change much in terms of the internals of GD

– You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/godotengine/godot/issues/7673#issuecomment-276070864

As long as the developer gets only the groups that he himself put in, doesn’t really matter how the internals of get_groups works. It’s a good idea to have get_groups remove everything starting with _ or maybe even __ in case someone decides for whatever reason to use a group name starting with _? Doing this wouldn’t change much in terms of the internals of GD