godot: md5 of imported source is in a wrong place
Godot version: Godot 3.0 b08735f20987a6188fd54c5e2dcd072dc316b413
OS/device including version: any OS
Issue description:
Currently source_md5 is located within the .import file near the source file. So when you change the source, reimport and commit the files, it doesn’t get reimported for other people who pull the changes. Shouldn’t it be located within the .import folder, associated with the imported file?
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Reactions: 2
- Comments: 15 (15 by maintainers)
BTW, while you could commit the
.importfolder, I don’t think you should. Git isn’t helpful for binary files, so adding copies of it in the same repository is just a waste of space. It’s more practical to let each contributor reimport stuff they need.@endragor Current check is against the source file, what I want to do is check against source AND imported file.
Ah, I see. Technically you can commit the .import folder now and it should work fine. That said, probably should add the MD5 of the imported files to the check…
On Wed, Dec 20, 2017 at 11:56 AM, George Marques notifications@github.com wrote:
The problem right now is that Godot is detecting that source file changes and goes and checks MD5 as it should, but it does not check the MD5 of the imported files, which it should.
@NathanWarden It’s simply easier to keep an md5 of the exported file. The editor filesystem keeps a cache of all modification dates anyway, so this check will only be performed if the date of the source file changes.
Yeah, I think the MD5 shouldn’t be commited, then it doesn’t belong to the
*.importfiles.