godot: ImageLoaderSVG: Couldn't set target on ThorVG canvas.

Godot version

4.0.beta16

System information

Windows 10, Vulkan, NVIDIA GeForce GTX 1050

Issue description

Importing SVG’s from Kenney.NL fails with the following message:

  ImageLoaderSVG: Couldn't set target on ThorVG canvas.
  core/io/image_loader.cpp:101 - Error loading image: res://assets/icons/skull.svg
  editor/editor_file_system.cpp:2004 - Error importing 'res://assets/icons/skull.svg'.

Steps to reproduce

Grab icons from Kenney.NL here: https://www.kenney.nl/assets/board-game-icons
Try importing an .svg from it
The process will fail:

Minimal reproduction project

N/A

About this issue

Original URL
State: closed
Created a year ago
Comments: 37 (21 by maintainers)

Commits related to this issue

Fix tvg::Picture->size() based errors. In some cases, useful for the web canvas but not for an image viewer, the image size() returns here width or height zerro. Render 1x1 px placeholder image, See... — committed to capnm/godot4 by capnm a year ago
Fix tvg::Picture->size() based errors. In some cases, useful for the web canvas but not for an image viewer, the image size() returns here width or height zerro. Render 1x1 px placeholder image, See... — committed to capnm/godot4 by capnm a year ago
Fix tvg::Picture->size() based errors. In some cases, useful for the web canvas but not for an image viewer the tvg::Picture->size() returns here width or height zerro. Render a 1x1 px placeholder im... — committed to capnm/godot4 by capnm a year ago
Fix tvg::Picture->size() based errors. In some cases, useful for the web canvas but not for an image viewer the tvg::Picture->size() returns here width or height zerro. Render a 1x1 px placeholder im... — committed to capnm/godot4 by capnm a year ago
Test godot+thorvg git tip Issue: https://github.com/godotengine/godot/issues/72478 Also needs PR https://github.com/godotengine/godot/pull/75034 — committed to capnm/godot4 by capnm a year ago
Update ThorVG to v0.9.0 https://github.com/thorvg/thorvg/releases/tag/v0.9.0 Fixes #72478 — committed to capnm/godot4 by capnm a year ago
Update ThorVG to v0.9.0 https://github.com/thorvg/thorvg/releases/tag/v0.9.0 Fixes #72478 — committed to capnm/godot4 by capnm a year ago
Update ThorVG to v0.9.0 https://github.com/thorvg/thorvg/releases/tag/v0.9.0 Fixes #72478 — committed to capnm/godot4 by capnm a year ago
Update ThorVG to v0.9.0 https://github.com/thorvg/thorvg/releases/tag/v0.9.0 Fixes #72478 — committed to capnm/godot4 by capnm a year ago
Update ThorVG to v0.9.0 https://github.com/thorvg/thorvg/releases/tag/v0.9.0 Fixes #72478 (cherry picked from commit 5db751832d54092c9d153c0fe07f9cc4616a2d01) — committed to akien-mga/godot by capnm a year ago
Update ThorVG to v0.9.0 https://github.com/thorvg/thorvg/releases/tag/v0.9.0 Fixes #72478 — committed to hakro/godot by capnm a year ago
Squashed commit of the following: commit 467eecb12bce4955fdb422aa2a171e45b94ae234 Author: Aaron Franke <arnfranke@yahoo.com> Date: Fri May 26 17:22:29 2023 -0500 Add a get_node_index method to... — committed to jeronimo-schreyer/godot by jeronimo-schreyer a year ago
Squashed commit of the following: commit 467eecb12bce4955fdb422aa2a171e45b94ae234 Author: Aaron Franke <arnfranke@yahoo.com> Date: Fri May 26 17:22:29 2023 -0500 Add a get_node_index method to... — committed to jeronimo-schreyer/godot by jeronimo-schreyer a year ago
Squashed commit of the following: commit 467eecb12bce4955fdb422aa2a171e45b94ae234 Author: Aaron Franke <arnfranke@yahoo.com> Date: Fri May 26 17:22:29 2023 -0500 Add a get_node_index method to... — committed to jeronimo-schreyer/godot by jeronimo-schreyer a year ago
Update ThorVG to v0.9.0 https://github.com/thorvg/thorvg/releases/tag/v0.9.0 Fixes #72478 (cherry picked from commit 5db751832d54092c9d153c0fe07f9cc4616a2d01) — committed to haunted-loaf/godot by capnm a year ago

Most upvoted comments

@mgrudzinska update: Both current godot 26fb911f79d7b16c46ca476923fe1f32ab5d27ed and thorvg 65116b87ada27689d79fa4db241cf777f3b268c5 github tip work together (the crash/dealock has been fixed). If the changes are in your next release, I don’t see any issues.

capnm on Apr 26, 2023

@mgrudzinska everything related to the image size and empty viewport/viewbox seems to be ok now. I have not yet received a response to #75034, I hope that one day it will be fixed too 😃

capnm on Apr 3, 2023

great, so I’ll take care now of this one extra pixel

mgrudzinska on Mar 21, 2023

@mgrudzinska

I hope that I’ve misunderstood - all of the images have a size equal 0? even if it shouldn;t be?

Most images show a picture 👍 I didn’t examine if they are correct cropped. The 0 size is no longer a bug after this patch. It renders 1 pixel images in this case.

From all test images, I posted:

The 0 size cases are: <svg width=“0”> (the Gnome Image Viewer: whole picture) -> t8.svg <svg viewBox=“0 0 0 200”> (giv: 1 pixel) <svg viewBox=“0 0 200 0”> (giv: 1 pixel) <svg viewBox=“0 0 0 0”> (giv: 1 pixel) <svg width=“0” height=“0” viewBox=“0 0 200 200”> (giv: 1 pixel) <svg width=“0” height=“200” viewBox=“0 0 20 20”> (giv: 1 pixel) same: <svg width=“0” height=“200” viewBox=“0 0 200 200”> <svg width=“200” height=“0” viewBox=“0 0 20 20”>

This renders a transparent 200x200 sized images (giv: 200x200 cropped picture): <svg width=“200” height=“200” viewBox=“0 0 0 0”> <svg width=“200” height=“200” viewBox=“0 0 0 200”> <svg width=“200” height=“200” viewBox=“0 0 200 0”>

</details

capnm on Mar 21, 2023

@mgrudzinska I haven’t had a chance to read through the code yet, had only a quick look at the SVG specs and Godot results with the last pr. The spec is, as you said, very css specific. Here, he also suggests, missing SVG size attributes should mean auto, so the whole image here, Godot now shows only 1x1 px image.

I missed this, I’ll solve this asap and let you know

mgrudzinska on Mar 13, 2023

@capnm I’ll try to make the pr ready asap - it is after rev and waiting for some changes.

mgrudzinska on Mar 9, 2023