gocd: Duplicated logs at the console on GoCD v17.11.0 on Safari and Firefox browsers

Issue Type

• Bug Report

Summary

On v17.11.0 of GoCD, when running a pipeline and visualizing the logs in the console on Safari (or Firefox) browser, they get duplicated. Note: After refreshing the page, the duplications are gone. Note 2: This is not perceived in Chrome, for instance.

Basic environment details

• Go Version: 17.11.0 (5520-9f6909e2f64b07d2dce5cecd4ea5b92b8e19d6b1)
• JAVA Version: 1.8.0_131
• OS: Linux 3.13.0-123-generic
• Browser vendor and version: Safari version 11.0.1 (13604.3.5)

Steps to Reproduce

1. Run any pipeline on Safari (or Firefox) with GoCD v17.11.0 and start looking at the console tab of the running job.

Expected Results

No duplications should be displayed in logs of the console.

Actual Results

Duplications are displayed in the logs of the console. Note: Sometimes duplications are displayed while the job is running and sometimes they are only displayed after the job is finished.

Screenshots

Other info

Notes from Gitter conversation:

Ketan Padegaonkar @ketan 10:37
what browser are you on, BTW?

Walmyr @wlsf82 10:38
I’m using Safari. Let me test on Chrome

Ketan Padegaonkar @ketan 10:38
that might be a culprit.
safari is known to have several issues with websockets (which is what accidentally got turned on in 17.11)

Walmyr @wlsf82 10:40
yeah, it doesn’t seem to happen on Chrome

Vierbergen Tim @VeeTeeDev 10:41
I think I was on Chrome or Firefox
not sure
but I'll check later

@wlsf82 — we can reproduce the issue on firefox. Its due websocket connection dropping off while the console logs are streamed.
`The connection to wss://build.gocd.org/go/console-websocket/<BUILD_URL>?startLine=0 was interrupted while the page was loading.`