rod: Send cdp request to non-exist sessions will cause hang
Rod Version: v0.80.0
The code to demonstrate your question
// in the top level rod directory
go test -run 'Test/Hijack'
Also two other unit tests reliably hang for me. ‘Test/PageWait’ and ‘Test/Mouse’. The other 160 odd pass.
What have you tried to solve the question
I’ve tried up to yesterday’s commit, ‘make test more stable’, and the results are the same.
Performing a git bisect, on my darwin system, with the latest Chrome (version 87), the last commit where they pass is a32cd66. The next one, 39dcf1c, causes each of the three tests listed above to hang.
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Reactions: 2
- Comments: 17
Commits related to this issue
- chrome hang for closing non-exist session id related to #283 — committed to go-rod/rod by ysmood 4 years ago
- prevent calling closed page Because send cdp request to non-exist sessions will cause hang. related to #283 — committed to go-rod/rod by ysmood 3 years ago
Agreed. They don’t seem to have the person power to tackle all their outstanding issues, so their triage is based on what their users have gotten used to and what is considered a regression.
I think your patch for the cleanup is fine for go-rod. That was one path that didn’t have a context timeout set while most normal use would want a timeout to help track down where things started to go wrong.