gitea: Tags missing on master since v1.1.0

I noticed that since v1.1.0, release tags are no longer picked up by git describe (and in turn show wrong in the interface footer). For example, from the current GitHub master:

$ git clone git@github.com:go-gitea/gitea.git .
$ git describe --tags
v1.1.0-894-g1687aa59

What’s weird is that the missing tags do show on git tag:

$ git tag | tail -1
v1.3.2

Anyone know what’s up?

About this issue

  • Original URL
  • State: closed
  • Created 7 years ago
  • Comments: 15 (14 by maintainers)

Most upvoted comments

Yes, that why I suggest 1.X.0-dev to show that it is a dev version as better alternative.

Tagging master branch for 1.x.0 version would mean that it would be frozen for 2-3 weeks more after rc1 for new features while we get out stable version

Tag before branch would definitely work as the tag is also visible on the branch, see below example workflow:

$ git init
$ git commit --allow-empty -m "first"
[master (root-commit) 8829b85] first
$ git tag v1.0.0 -m v1.0.0
$ git commit --allow-empty -m "second"
[master f6f310f] second
$ git describe
v1.0.0-1-gf6f310f
$ git branch branch
Branch 'branch' set up to track local branch 'master' by rebasing.
$ git checkout branch
Switched to branch 'branch'
Your branch is up to date with 'master'.
$ git describe
v1.0.0-1-gf6f310f