gitea: Error while getting .editorconfig file

Description

I found this message in /admin/notices

Error while getting .editorconfig file: normalization error: insert_final_newline=off is not an acceptable value. strconv.ParseBool: parsing "off": invalid syntax

Nothing founded in gitea.log.

Gitea Version

1.17.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

image

Git Version

2.25.1

Operating System

Ubuntu 20.04.4

How are you running Gitea?

Downloaded gitea-1.17.0-linux-amd64

Database

PostgreSQL

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 19 (15 by maintainers)

Commits related to this issue

Most upvoted comments

So maybe the proposal could be: “Make Gitea not report user’s editorconfig syntax error as repository notice”, or only show the syntax error on the proper page clearly.

Yes, https://github.com/go-gitea/gitea/pull/21257 got stalled. I think it’s the right solution to parse graceful and display errors. Ideally the admin page could also show the affected repo, or the admin notice could also be removed entirely.

Hmm, logging these parser “warnings” might be hard to consume. How about adding a warnings slice to a parse result, e.g.?

type Editorconfig struct {
  Root        bool
  Definitions []*Definition
  config      *Config
  warnings    []string
}

Fatal errors should still return err of course.

On a related note, according to https://stackoverflow.com/a/57682840/808699, YAML 1.2 dropped the yes/no on/off aliases, so I think it’s probably wise to follow and be strict about true/false/unset, which is also in-line with the spec.

@silverwind agreed. Most of them, could be moved to an error as log.