github-changelog-generator: Pull requests missing
Describe the bug
We recently noticed that in latest releases of our Seldon Core the Merged pull requests section is missing.
To Reproduce
Full changelog with missing pull requests for releases 1.8 and 1.9 is here.
Steps to reproduce the behavior:
- Clone seldon-core
- Checkout master
- Execute
docker run --rm -it -v $(pwd):/work -w /work ruby bash -c 'gem install github_changelog_generator && bash'
github_changelog_generator -u seldonio --token [github api token here to avoid limits] --project seldon-core
- See lots of errors of form
Warning: PR 3222 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3217 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3211 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3209 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3205 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3203 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3200 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3193 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3191 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3188 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3183 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3172 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3171 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3166 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3163 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3160 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3159 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3155 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3153 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3152 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3151 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3147 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3142 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3141 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3135 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3134 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3123 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3118 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3117 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3116 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3110 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3104 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3101 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3099 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3095 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3094 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3093 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3092 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3090 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3089 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3088 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3086 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3085 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3083 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3082 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3081 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3078 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3076 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3074 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3060 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3055 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3048 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3044 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 3014 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 2959 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 2955 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 2920 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 2917 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 2895 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 2742 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 2740 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 2270 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 2268 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 1795 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Warning: PR 659 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
Expected behavior
No errors and pull requests always included.
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
- OS: Docker on Ubuntu 20.04
- Browser [Chrome but N/A]
- Version [20.04]
Additional context Add any other context about the problem here.
About this issue
- Original URL
- State: open
- Created 3 years ago
- Reactions: 9
- Comments: 44 (10 by maintainers)
Commits related to this issue
- release 4.30.0 This changelog was generated by hand because of https://github.com/github-changelog-generator/github-changelog-generator/issues/971 — committed to bastelfreak/beaker by bastelfreak 3 years ago
- release 4.30.0 This changelog was generated by hand because of https://github.com/github-changelog-generator/github-changelog-generator/issues/971 — committed to bastelfreak/beaker by bastelfreak 3 years ago
- Release 5.0.0 This changelog was crafted by hand, due to https://github.com/github-changelog-generator/github-changelog-generator/issues/971 I used https://github.com/voxpupuli/beaker/compare/4.39.0.... — committed to bastelfreak/beaker by bastelfreak a year ago
For those of you seeing this issue, is it happening when your release branch is not the repository’s default branch? If so, then #979 should fix it for you once merged / released
Do we have any update on this maybe? A chance that it could be fixed in the upstream or some sort of FAQ added with an official workaround?
Can you reproduce it? I’m kind of in a catch 22 situation in using tagging as a workaround, because I need to update the changelog before tagging (because tagging is what starts my package upload/release process), and I right now I cant do that 😃
I’m still dreaming of a fix @olleolleolle @skywinder 😃
Hi people. This still happens with the latest master branch of github-changelog-generator. I cannot push a temporary tag to GitHub because that would automatically release it. Has someone else an idea what’s happening here?
As a workaround, I created a temporary new tag (e.g.
temp-tag) on the release branch (in my case, it’s calledmain, which is also the default branch). Then, I re-ran the command to the previous release tag I wanted (e.g. v1.2.5).Then I ran the command it worked. I then deleted the tag locally and in github, to clean things up again.
Still no word from @olleolleolle or any other maintainers?
@cyberw I’m currently experimenting with using release-drafter instead
Hi, I can reproduce this with all repos I tried from the voxpupuli github org, for example https://github.com/voxpupuli/beaker/pull/1711. This worked fine in the past. I tried downgrading github-changelog-generator but I get the same error on 1.16.3, 1.16.2 and 1.16.1. I also downgraded octokit to 4.20.0. All without luck. Maybe something in the github api changed? or one of the other dependencies?