litvis: Litvis broken in Atom 1.38.x and above
It looks like the changes in Atom from 1.37 -> 1.38 have broken our markdown-preview-enhanced-with-litvis plugin.
We need to realign our fork with markdown-preview-enhanced which does work in Atom 1.38.0.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 18 (18 by maintainers)
A fix for the VSCode extension has been made in https://github.com/gicentre/vscode-markdown-preview-enhanced-with-litvis/pull/2 and released as 0.12.0.
I’m closing this issue as the substantial issue of running markdown-preview-enhanced-with-litvis with latest Atom and mume has been fixed (thanks Alex!). I’ll open a separate issue on prettier-plugin-elm not being detected when npm globals are in a non-standard location.
prettier --support-in | grep elmin a clean folder givesOpening atom from the command line in a non project folder and then opening a file that needs formatting still just formats the javascript blocks but not the elm blocks when formatting via ctrl-option-F
Tested with completely clean install of atom and node. Following the install instructions to the letter installs the following versions from the command line:
node --versionv10.16.3npm --version6.9.0elm --version0.19.0prettier --version1.18.2Atom 1.40.1
markdown-preview-enhanced-with-litvis 0.17.0
language-elm 1.5.0
busy-signal 2.0.1
linter 2.3.1
language-markdown 0.37.0
prettier-atom 0.57.2
A simple litvis doc with spec works and renders with no console errors.
But, as you hinted, elm-format does not work, so presumably some problem with prettier-plugin-elm. JavaScript code blocks also fail to be formatted properly, so not specific to elm.
Manual formatting from the command line works for elm and javascript code blocks:
prettier helloWorld.md --write@jwoLondon could you please check Atom plugin v 0.17.0 on the latest Atom? I clicked through some of our examples and they appeared to be working for me.
I’ll get to fixing the VSCode extension once we confirm that everything works in Atom. There’ll have to be a pull request similar to https://github.com/gicentre/markdown-preview-enhanced-with-litvis/pull/1.