sc2reader: Ability list for recent builds is incorrect

The the current new_units.py and the shell commands listed in the HOWTO do not preserve the command index of the ability when populating ability_lookup.csv. This means that the abilities with the same ability link but different command indices end up mapping to the same ability id.

This can be easily verified by loading a replay (with game events) where the player builds a supply depot and a barracks. The supply depot command event will have the correct ability name, but the barracks command event will not.

About this issue

Original URL
State: closed
Created 8 years ago
Reactions: 1
Comments: 33 (20 by maintainers)

Most upvoted comments

@dsjoerg @ccopland94 First PR: https://github.com/ggtracker/sc2reader/pull/22

frugs on Jun 8, 2017

OK, then I think we are largely agreed on how we think the resolution of this issue should be progressed. I can start working on a PR for a script which will will generate correct [build]_abilities.csv from the balance data xml (i.e. a replacement for the now-defunct shell command described in HOWTO).

The next step would be to add a script which will be able to add any new commands found in new balance data xml files with the correct command indices to ability_lookup.csv.

Finally, updating the HOWTO with instructions on how to use these new scripts should resolve this issue.

It would then probably be wise to consider further improvements to the system overall (e.g. tie command indicies to balance versions, tie the data contained in train_commands.json to balance versions, combine [build]_abilities.csv and ability_lookup.csv into one table etc.)

frugs on Jun 8, 2017