sentry-javascript: Unable to filter safari extensions

Review the documentation: https://docs.sentry.io/
Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
Use the latest release: https://github.com/getsentry/sentry-javascript/releases
Provide a link to the affected event from your Sentry account

Package + Version

@sentry/browser
@sentry/node
raven-js
raven-node (raven for node)
other:

Version:

6.2.0

Description

Chrome extensions are easy to filter out:

denyUrls: [/^chrome-extension:\/\//i]

But when I try it with safari extensions, sentry doesn’t filter it out:

denyUrls: [/safari-(web-)?extension:/]

I even tried with ignoreErrors:

ignoreErrors: [/safari-(web-)?extension:/]

but to no avail. That is extremely weird, because I thought ignoreErrors checks for match in raw error string, which 100% contains safari-extension:or safari-web-extension:. See example:

Error: {} at ClipperError@safari-extension:(//3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/commons.js:223036:10) at fromAny@safari-extension:(//3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/commons.js:223078:28) at _handleResponsePromise@safari-extension:(//3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/commons.js:202805:51) at _handleDispatchResponse@safari-extension:(//3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/commons.js:202784:32) at _handleMessage@safari-extension:(//3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/commons.js:202766:37) at safari-extension:(//3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/commons.js:202755:26) at emit@safari-extension:(//3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/topee-content.js:3507:17) at safari-extension:(//3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/topee-content.js:3313:26)

Am I doing sometihing wrong? Is there a way to filter safari extensions out?

About this issue

Original URL
State: closed
Created 3 years ago
Reactions: 1
Comments: 25 (9 by maintainers)

Most upvoted comments

@senky the fix is coming 😃 Hi, I have a question about this answer. I faced a similar problem, how can I ignore safari-extension? I want to ignore all errors caused by chrome-extension and safari-extension. For your information, ‘Filter out errors known to be caused by browser extensions’ is turned on.

It’s an error I got.

TypeError: undefined is not an object (evaluating ‘g.toString’) at safari-extension:(//260B6E24-727B-43D5-ACB5-55C5A7B2EE46/4245c0c1/Honey.safariextension/h1-vendors-main-popover-wallet.js:51:75573) at u@safari-extension:(//260B6E24-727B-43D5-ACB5-55C5A7B2EE46/4245c0c1/Honey.safariextension/h1-vendors-main-popover-wallet.js:147:37625) at safari-extension:(//260B6E24-727B-43D5-ACB5-55C5A7B2EE46/4245c0c1/Honey.safariextension/h1-vendors-main-popover-wallet.js:147:37375) at r@safari-extension:(//260B6E24-727B-43D5-ACB5-55C5A7B2EE46/4245c0c1/Honey.safariextension/h1-vendors-main-popover-wallet.js:51:77376) at safari-extension:(//260B6E24-727B-43D5-ACB5-55C5A7B2EE46/4245c0c1/Honey.safariextension/h1-vendors-main-popover-wallet.js:51:77472) at promiseReactionJob([native code])

OMTI-Seyoon on May 7, 2021

@senky the fix is coming 😃

kamilogorek on Apr 7, 2021

Thanks @trmpowell! https://github.com/getsentry/sentry-javascript/pull/3929 should fix it soon.

kamilogorek on Aug 27, 2021

Ah, it looks like your PR went in after 6.12.0. We will upgrade. Thanks!

trmpowell on Sep 27, 2021

Yes, will do. I’ll get back to you when we see the event again.

frigus02 on May 25, 2021

Thanks, that’s helpful. Apparently the raw stack looks slightly differently, and SDK was not able to parse it correctly, which makes the filename and abs_path values malformed (abs_path is used for this filtering). However, to tell what went wrong, we need the raw stack in the first place. And to obtain it, we need to attach it to the event.

Could you use the snippet below to configure your SDK and get back to me once you notice the same issue again? This time it should have additional data attached.

Sentry.init({
  beforeSend(event, hint) {
    try {
      if (hint.originalException.message === `undefined is not an object (evaluating 'g.toString')`) {
        event.extra = event.extra || {};
        event.extra.rawStack = hint.originalException.stack;
      }
    } catch (e) {
      return event;
    }

    return event;
  },
});

kamilogorek on May 25, 2021

No, you need to do this only: https://github.com/getsentry/sentry-javascript/issues/3313#issuecomment-812478660

kamilogorek on May 11, 2021

can we pass in something like denyUrls: [/^chrome-extension:\/\//i, /safari-(web-)?extension:/],?

catchanuj on May 10, 2021

Browser extensions can be filtered directly in the UI (which also saves your event quota), so there’s no need to change SDK config 😃

kamilogorek on Apr 2, 2021