sentry-javascript: Some browser integrations does not respect the Integration#setupOnce signature

Package + Version

  • @sentry/browser
  • @sentry/node
  • raven-js
  • raven-node (raven for node)
  • other:

Version:

5.0.0

Description

Hi,

It seems the integration (provided by the browser package) does not implement the correct signature of setupOnce, eg: https://github.com/getsentry/sentry-javascript/blob/master/packages/browser/src/integrations/globalhandlers.ts#L50 https://github.com/getsentry/sentry-javascript/blob/master/packages/browser/src/integrations/useragent.ts#L22 https://github.com/getsentry/sentry-javascript/blob/master/packages/browser/src/integrations/trycatch.ts#L172 https://github.com/getsentry/sentry-javascript/blob/master/packages/browser/src/integrations/linkederrors.ts#L43

(maybe others)

Regards

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Comments: 20 (9 by maintainers)

Most upvoted comments

Ohhh, I know that the problem is, Integrations only work if there is a currentHub, we have to add this to the documentation.

Please make sure you do the following:

import { makeMain } from "@sentry/hub";

// YOUR CODE
// after you have the hub instance

makeMain(hub);

Hope this fixes it. Edit: You probably have to install @sentry/hub

+1
HazAT on Apr 1, 2019
Read more comments on GitHub
← sentry-javascript: SentryWebpackPlugin.cliBinaryExists is not a function
sentry-javascript: Source code was not found for index.js →