sentry-javascript: https.request is broken by agent-base included by https-proxy-agent

Package + Version

@sentry/node

Version:

4.6.6
5.3.0

Description

Some time after 4.1.1 sentry started depending on https-proxy-agent. https-proxy-agent depends on agent-base which does a little nasty thing where it patches over node-core’s https.request here

Problems are:

this patch only supports the 2 parameter form.
this patch does not support any forms where a URL object is passed in (instead of the string) due to its reliance on Object.assign

Docs on node’s https.request

Unfortunately this means any app that depends on @sentry/node also receives this lovely bug.

About this issue

Original URL
State: closed
Created 5 years ago
Reactions: 2
Comments: 18 (11 by maintainers)

Commits related to this issue

fix: Force agent-base to be at version 4.3.0 to fix various issues Fixes #1762, fixes #2085. — committed to getsentry/sentry-javascript by BYK 5 years ago
fix: Force agent-base to be at version 4.3.0 to fix various issues (#2108) Fixes #1762, fixes #2085. — committed to getsentry/sentry-javascript by BYK 5 years ago

Most upvoted comments

TIL 🙃

kamilogorek on Sep 13, 2019

Hi we are seeing this issue still. Is there any eta on releasing a possible fix? Specifically seeing new relic external calls breaking, as described here: https://github.com/getsentry/sentry-javascript/issues/2155

sanchezjjose on Sep 13, 2019

PR pending https://github.com/TooTallNate/node-agent-base/pull/28

kamilogorek on Jul 10, 2019