sentry-java: Unable to set tags at different levels
If sentry is configured for instance in sentry.properties with tags=commitHash:a5e39b08 and has env property, SENTRY_TAGS=“namespaceK8s:test”, then tags map is { namespaceK8s: test } while I would have expect tags to be merged in { namespaceK8s: test, commitHash: a5e39b08}.
I could prepare a pull request to fix it, but I would to know if it may be accepted before.
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Reactions: 2
- Comments: 15 (14 by maintainers)
Commits related to this issue
- #874 Unable to set tags at different levels — committed to DCbrainOrg/sentry-java by mmadoo 4 years ago
- #874 Unable to set tags at different levels — committed to DCbrainOrg/sentry-java by mmadoo 4 years ago
- #874 Unable to set tags at different levels (#875) — committed to getsentry/sentry-java by mmadoo 4 years ago
- Merge external map properties Fixes #874 — committed to getsentry/sentry-java by maciejwalkowiak 3 years ago
- Merge external map properties Fixes #874 — committed to getsentry/sentry-java by maciejwalkowiak 3 years ago
- Merge external map properties (#1656) Fixes #874 — committed to getsentry/sentry-java by maciejwalkowiak 3 years ago
I agree, maybe the community could help with it, we accept PRs 😃
Agree it isn’t a bug, it’s a feature we dropped. Lets keep it open while we discuss how to proceed here. We’re considering adding an integration that will bind
SENTRY_things into sentry options. Lets see how relevant to folks this is to prioritize this.We either work on performance support or 1000 ways to load configs into the SDK. I believe we’d add more value adding performance support
In v3 we do not merge configurations and we do not support setting tags externally. Perhaps something for 3.1?