sentry-java: Exception cause hierarchy seems to be reversed on Android

Here’s what I mean.
New: Old:

Having the exception message there at the top level makes it way easier to triage effectively. Especially on the list view: New: Old:

it actually walks down the exception chain and finds the topmost Exception that includes the app’s package name

Oh interesting, I think I missed that. Thanks much for the examples.

OK, with the random stuff I had to get to and 1.3.0 out the door I will give this one some real time next week.

Oh yeah, sorry, I had to go re-read some of this thread myself. I forgot about the whole culprit/transaction business…com.joshdholtz.sentry doesn’t just use traces[-1], it actually walks down the exception chain and finds the topmost Exception that includes the app’s package name. Which is great, because if I choose to wrap exceptions, it’ll give me the wrapper exception, but if it’s Android wrapping everything in a RuntimeException, I’ll get the one below that.

I just wrote ^ and realized it’s really dense, so a couple examples, given that my app’s package name is com.example.foo, and I have these custom exception classes: com.example.foo.TheActualCauseException, com.example.foo.MyWrapperException.

1. The Android-wrapped-me case: RuntimeException -> com.example.foo.TheActualCauseException. This should log TheActualCauseException to Sentry.
2. The I-wrapped-it-myself case: RuntimeException -> com.example.foo.MyWrapperException ->com.example.foo.TheActualCauseException. This should log MyWrapperException to Sentry (presumably because I’ve included additional information that wasn’t part of TheActualCauseException).

@bretthoerner I will ask here, but I don’t have the admin rights here yet so actually I believe I can’t. But I can share some screenshots:

Here are 3 issues, one was ClassCastException, another was IllegalStateException and the third was yet another unrelated issue on the same Activity class. But from the outside, there’s no way to know what really is the issue.

ClassCastException issue in details, now we can see what really is it:

Its not that it don’t looks right, it is in fact a RuntimeException, but the ‘culprit priority’ looks messy and makes user experience bad in the end.

Thanks for reporting, it’s good to hear from another Android user (as I’m not an actual Android dev, I just pretend to be one on TV).

Just to be clear, would the inner-most exception be the error you’d like to see (as reported above)? Or is it more complex than that?

Ah, that makes sense. Can you review this? https://github.com/getsentry/sentry-java/pull/413