grav: File upload triggers exceptions
I just upgraded to 1.1.0 and media uploads seems to trigger a few exceptions. This brings the whole site down (my visitors get HTTP 500) until I remove the cache/compiled/files file manually.
The weird thing is that files is an actual file when I get the 500 error, but in other cases it is a directory. I think something creates files as a file, thus mkdir files raises and exception somewhere.
Logs from my error.log
2016/07/15 20:02:39 [warn] 15056#15056: *23 a client request body is buffered to a temporary file /var/cache/nginx/client_temp/0000000018, client: 115.187.195.164, server: privacyforjournalists.org.au, request: "POST /admin/media/guides/encrypt-your-hard-drive-with-bitlocker-windows.json/task:addmedia HTTP/1.1", host: "privacyforjournalists.org.au", referrer: "https://privacyforjournalists.org.au/admin/pages/guides/encrypt-your-hard-drive-with-bitlocker-windows"
2016/07/15 20:02:39 [error] 15056#15056: *23 FastCGI sent in stderr: "PHP message: PHP Fatal error: Uncaught exception 'RuntimeException' with message 'Creating directory '/var/www/privacyforjournalists.org.au/html/cache//compiled/files' failed on error mkdir(): File exists' in /var/www/privacyforjournalists.org.au/html/vendor/rockettheme/toolbox/File/src/File.php:420
#0 /var/www/privacyforjournalists.org.au/html/vendor/rockettheme/toolbox/File/src/File.php(195): RocketTheme\Toolbox\File\File->mkdir('/var/www/privac...')
#1 /var/www/privacyforjournalists.org.au/html/vendor/rockettheme/toolbox/File/src/File.php(316): RocketTheme\Toolbox\File\File->lock()
#2 /var/www/privacyforjournalists.org.au/html/vendor/rockettheme/toolbox/File/src/PhpFile.php(31): RocketTheme\Toolbox\File\File->save(Array)
#3 /var/www/privacyforjournalists.org.au/html/system/src/Grav/Common/File/CompiledFile.php(66): RocketTheme\Toolbox\File\PhpFile->save(Array)
#4 /var/www/privacyforjournalists.org.au/html/system/src/Grav/Common/Config/Setup.php(165): Grav\Common\File\CompiledYamlFile->con" while reading response header from upstream, client: 115.187.195.164, server: privacyforjournalists.org.au, request: "POST /admin/media/guides/encrypt-your-hard-drive-with-bitlocker-windows.json/task:addmedia HTTP/1.1", upstream: "fastcgi://unix:/var/run/php5-fpm-web1.sock:", host: "privacyforjournalists.org.au", referrer: "https://privacyforjournalists.org.au/admin/pages/guides/encrypt-your-hard-drive-with-bitlocker-windows"```
About this issue
- Original URL
- State: closed
- Created 8 years ago
- Reactions: 1
- Comments: 16 (8 by maintainers)
Commits related to this issue
- cache/compiled upload fix for https://github.com/getgrav/grav/issues/938 — committed to getgrav/grav-plugin-admin by rhukster 8 years ago
This fixes the problem and restores the website:
@gszathmari indeed your solution works! A BIG thank you! May I just explain how I got into the need for this solution? Because I cannot find it anywhere.
In our Linux configuration (BlueOnyx) the site storage allocation and the “user” allocation is entirely different and as there is no database in grav, my user was clocking up data for backups etc. Eventually, I was installing a theme and I got an error that Grav could not perform MKDIR. It half created the template (it just had a letter “v” in the top left corner) and I had to remove it via CLI and clear cache as described above. Increased my storage allocation for user and everything working great again. I don’t know if Grav could perform a simple MD5 checksum when it installs a theme or plugin and to drop the package if it does not match? Just a thought…
yes, i was able to reproduce the exact error on my raspberry pi with PHP7 and nginx+php-fpm. It was not while uploading, it was while deleting a bunch of files via the admin. it happened randomly, like part of the filename was lost, and it renamed the folder
files/to a file calledfileand that really broke things. I did get an invalid ajax method…The only problem is that I only got it twice and can’t get it to happen again for some reason. I’ll keep trying this weekend though and digging in a bit further.