NativeBase: missing typescript definitions in 2.1
Hi, just want to inform you that the following are missing from typescript definitions:
getTheme, StyleProvider
For now I have manually changed my local index.d.ts for native-base, but you should definitely include these in the future releases. tnx
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Reactions: 13
- Comments: 17 (9 by maintainers)
Commits related to this issue
- added missing typescripts #693 — committed to GeekyAnts/NativeBase by shivrajkumar 7 years ago
@SupriyaKalghatgi No new reports since Apr 18
Here is compiled list:
StyleProviderPR https://github.com/GeekyAnts/NativeBase/pull/955~~FormPR https://github.com/GeekyAnts/NativeBase/pull/758~~LabelPR https://github.com/GeekyAnts/NativeBase/pull/607~~FabPR https://github.com/GeekyAnts/NativeBase/pull/465~~ActionSheetSegmentToastPR https://github.com/GeekyAnts/NativeBase/pull/758~~Tab.onChangeTabPR https://github.com/GeekyAnts/NativeBase/commit/27b03322016229eed2c1882215eba32875861243~~Header.noShadowPR https://github.com/GeekyAnts/NativeBase/commit/27b03322016229eed2c1882215eba32875861243~~ListItem.noBorderPR https://github.com/GeekyAnts/NativeBase/commit/27b03322016229eed2c1882215eba32875861243~~ContentdisableKBDismissScrollPR https://github.com/GeekyAnts/NativeBase/commit/27b03322016229eed2c1882215eba32875861243~~enableResetScrollToCoordsPR https://github.com/GeekyAnts/NativeBase/commit/27b03322016229eed2c1882215eba32875861243~~RootPR https://github.com/GeekyAnts/NativeBase/commit/d382044969fe5e088c8ae5dde30a9973c7d9d444~~getThemeNativeBaseComponentButtonbadgeverticalI can check if definitions are still missing and make PR for (some)all if you approve it. @
@shivrajkumar do you support @AleksandarDev making a PR for additional typescript definitions?
@mcd-php @PaitoAnderson
Rootis now in d.ts (added 8 days ago by shivrajkumar) you can take it from master or wait for next buildRootis also missingThere aro two ways that I can think of.
First is to use spread operator like
<Tabs {...{ onChangeTab: this.handleActiveTab } }>And the second way is to just change index.d.ts inside node_modules\native-base and just add what is missing. Bad thing with this it will be overwritten when you upgrade native base, unless you add this file to your source control.
Also missing:
noShadowproperty ofHeadernoBorderproperty ofListItemDoes anyone has workaround for manually extending type definitions to prevent
tscfrom failing?These components are also missing from tsd
ActionSheet, Form, Segment, Toastand Tabs component is missing function
onChangeTab()