ngx-chips: Custom theme not possible in 1.6.1 (missing .scss file)
PLEASE MAKE SURE THAT:
- you searched similar issues online (9/10 issues in this repo are solved by googling, so please…do it)
- you provide an online demo I can see without having to replicate your environment
- you help me by debugging your issue, and if you can’t, do go on filling out this form
I’m submitting a … (check one with “x”)
[X] bug report => search github for a similar issue or PR before submitting
[ ] support request/question
Notice: feature requests will be ignored, submit a PR if you'd like
Current behavior
As the documentation says, in order to make a custom theme we have to import ngx-chips/dist/modules/core/styles/core/_core.scss
In version 1.6.1 this file no longer exists, so trying to import it gives an error.
Expected behavior
To be able to import the .scss file to make a custom theme.
Minimal reproduction of the problem with instructions (if applicable)
Use @import "~node_modules/ngx-chips/dist/modules/core/styles/core/_core.scss";
What do you use to build your app?. Please specify the version
angular-cli 1.6.0
Angular version:
5.1.0
ngx-chips version:
1.6.1
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
all
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Reactions: 5
- Comments: 26 (7 by maintainers)
Commits related to this issue
- #632, #604: Upgrade ng-packagr & Copy SCSS files to output Upgraded ng-packagr to latest version and fixed compile errors or warning. Added a step to copy SCSS manually to distributables in new folde... — committed to hspier/ngx-chips by deleted user 6 years ago
- #632, #607: Upgrade ng-packagr & Copy SCSS files to output Upgraded ng-packagr to latest version and fixed compile errors or warning. Added a step to copy SCSS manually to distributables in new folde... — committed to hspier/ngx-chips by deleted user 6 years ago
- Fixes #607 & #632 (#661) * #607: Migrate to Angular 5 and RxJS 5.5 with pipeable operators Migrate component to Angular 5, upgrading TypeScript, WebPack and RxJS. Use pipeable operators from RxJS.... — committed to Gbuomprisco/ngx-chips by hspier 6 years ago
It appears scss files are not being moved with the new build process, stick to the version 1.5.11 while this gets fixed
1.6.3-rc.3
works with@import "~ngx-chips/core/styles/core/_core.scss"
on AOT buildsHey @Gbuomprisco, can confirm that 1.6.3-rc.3 is working for us.
The location of the core stylesheet has moved so needed updating in our SASS code:
Old:
@import "~ngx-chips/dist/modules/core/styles/core/_core.scss";
New:
@import "~ngx-chips/core/styles/core/_core.scss";
Also compiled correct using
ng build --prod --aot false
Thanks very much