BackstopJS: Wrong src link in html report for ressemble images
Hello,
In the report the link to the ressemble is wrong.
What is in the src :
..\..\C:\Projets\N3\fwd-webapp-overlay-skin\backstop_data\bitmaps_test\light\20161004-130641\failed_diff_01046322484_Tous_les_headings_0_n3-doc-heading_0_phone.png
What it should be :
C:\Projets\N3\fwd-webapp-overlay-skin\backstop_data\bitmaps_test\light\20161004-130641\failed_diff_01046322484_Tous_les_headings_0_n3-doc-heading_0_phone.png
Seems like it adds "…\ …" too many before the C:
Thanks!
About this issue
- Original URL
- State: closed
- Created 8 years ago
- Comments: 28 (10 by maintainers)
Commits related to this issue
- Possible fix for #300 — committed to garris/BackstopJS by garris 8 years ago
- Revert "Possible fix for #300" This reverts commit dcacb60fc38db6911f745bf695ae8faa921ddffe. — committed to garris/BackstopJS by garris 8 years ago
Boom! Found it… https://github.com/garris/BackstopJS/blob/master/core/command/report.js#L24
Ok. I think you found a real live bug! I will try to look at this on the train home. Thank you for reporting.
@Spydr331 @stephenbe @fabioduque Brilliant teamwork!!! You guys rock – thank you for the help! I will push a revision after I get out of my AM meetings.
Ok. Sorry guys. I am fairly certain this is a win only issue. My guess is that somewhere in the codebase we may be looking for a (string[0] === ‘/’) to test for relative paths – or something like that. Any help on this would be greatly appreciated as I am totally slammed today! Thanks! GS
Is everyone on windows?
@garris @stephenbe Awesome fix and more points for you, for fixing it on the move!! I agree also with the teamwork! That’s why open source will ALWAYS be better! 😄 Cheers for all!
Well, I guess it’s pretty good for free software! 😆
@garris Nice!!!
Same here!
I’m also experiencing this issue.