react-hot-loader: 4.3.12 breaks polyfills for IE11
Description
Upgrading from 4.3.11 to 4.3.12 breaks polyfilling for IE11.
Expected behavior
It should continue to work. 😃
Actual behavior
No error messages during build but polyfills stops working. They seem to be in the code but not executing or something.
Environment
React Hot Loader version: 4.3.12 webpack 4.25.1 @babel/preset-env 7.1.5
Run these commands in the project folder and fill in their results:
node -v: 10.13.0npm -v: 6.4.1
Then, specify:
- Operating system: macOS Mojave
- Browser and version: IE 11
Reproducible Demo
No repo at this time - sorry. 😦
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 15
Commits related to this issue
- fix: startsWith not defined in IE, #1099 — committed to gaearon/react-hot-loader by theKashey 6 years ago
- fix: IE11 compact, #1099 — committed to gaearon/react-hot-loader by theKashey 6 years ago
I’ll release a fix tomorrow. It’s to late for me to draft any release today.
Sorry for delay. I wanted to release this change with another one, but (and this is the nature of RHL) even having all the tests green - it does not work in real. Trying to find problem…
Any updates? 😃
Fell free to upgrade to 4.4.0-1 (beta). It fixes this and another issues.
This file: https://github.com/gaearon/react-hot-loader/blob/master/src/proxy/createClassProxy.js Uses string method that IE11 does not support: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/startsWith
I see error in IE11 console: SCRIPT438: Object doesn’t support property or method ‘startsWith’