PyFunceble: We should not produce output in a certain case

We should not write or produce output if an element which is in the database is still ACTIVE or INVALID on retest.

@dnmTx said (https://github.com/anudeepND/blacklist/issues/27#issuecomment-450926668):

@funilrys i got your point but it makes me wonder what good are they doing in a folder that is design to collect invalid domains that came from the original lists during filtering.In our case here they’re no longer present there(in the orig. lists).Maybe a sub folder for collecting a “old,no longer present invalid domains”? So they can pile up there and keep the main folder tight,with only the fresh ones.

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Comments: 29 (12 by maintainers)

Commits related to this issue

Most upvoted comments

Hi @smed79 the assorted repo was created when we migrated to the actual infrastructure. I will leave it as it is until I talked with Mitchell.

Will do asap @smed79 👍

Fix of @dnmTX last report (https://github.com/funilrys/PyFunceble/issues/16#issuecomment-451762777) introduced with https://github.com/funilrys/PyFunceble/commit/784ad727a426652e9dbb934525e4a1d321cf9644.

It is now in the dev version.

P.S: As @Ultimate-Hosts-Blacklist now use the master/stable version it will be effective from the time this issue will be reclosed automatically.

@anudeepND i know.You mentioned it in the issue i opened in your repo. No apologies needed as i’m only trying to make you aware of the situation so you can do some cleaning.I’m not affected as i’m loading your lists from the Ultimate-Hosts-Blacklist,specifically the clean.list which is already filtered from anything possible(dead,invalid,whitelist and so on,and so on). I would advise you to go by what is in the INVALID folder,see if you missed something and then check only the commits to that particular folder every week or so to see if anything new show up until @funilrys sort this one out and leave only the newcomers in the folder.

@dnmTX: @dead-hosts use the dev version by default but members/maintainers can switch to the stable if they want 😄

Sooo, yes any changes here are there too 😉

@dead-hosts is actually the first place to use PyFunceble… You don’t even have to think about how to use PyFunceble if your list are tested at @dead-hosts 😄

I agree with you, too many lists is confusing… 😕

They are relevant for ALL countries/locations especially for those users who visit streaming, torrent or adult sites. The malvertising ad networks that you have mentioned are using rotating domains trying to escape ad blockers. For that reason strict blocking is applied by EasyList for some sites (e.g. #p130918).

getadmiral list has the purpose of blocking the anti adblock wall https://vgy.me/1mqjc4.jpg some sites here where it is used https://ghostbin.com/paste/uzocj/raw

PS:

  • I am planning to maintain another list which will block ad-maven.com revolving adservers.
  • when I will have some free time, I am going to merge the lists mentioned in one full list.

@funilrys for some reason in smed79_propellerads_adservers there is no clean.list. Could be a bug.

for the “assorted” repo, I do not remember that I am at the origin of creating that repo.

I do a search in my email-box and find the below conversations about cliqz.com https://git.io/fhZUB https://github.com/mitchellkrogza/Ultimate.Hosts.Blacklist/commit/fbad015220e8c94eed9930d10901065dc6d44a35

It’s unclear for me what this repo will inclut, so I am not going to maintain it.

@funilrys I sent you a request via email about creating a repo with the purpose of blocking “popads revolving ad servers”.

Thank you.

Hi, propellerads revolving adservers added ==> domains.list for the “assorted” repo, I do not remember that I am at the origin of creating that repo.

thank you for notifying.

Please create an issue or create an internal discussion at @Ultimate-Hosts-Blacklist as @smed79 is responsible of those mentioned repository! We only provide the infrastructure!

I’ll wait awhile to see if @smed79 respond to the discussion here.If he doesn’t,i will.

@dnmTX will keep this closed until it is not the case 😸 I’m already on the monitoring since I pushed it to the dev version 😉 For now, I can tell that it is working!

@anudeepND yes, it’s the expected behavior 👍

@anudeepND it doesn’t get updated at the present aka removing the old(non existent)entries and only leaving if there is a new ones.That’s why i told you for now(at least) to check the “COMMITS” to that folder and see if anything new is added.This is what this post(issue) is about: me and @funilrys debating on what to do with all those domains that already has been removed from your original lists but still remain in the INVALID folder.So stand by as @funilrys got the last word here…

@dnmTX @funilrys All these invalid domain came from a sub domain scanner I used months ago. I didn’t take a closer look at the output, which made those domains to be ended up on the final list. Sorry for that 😃 I will take closer look, line by line if possible to remove them.

Edit: The domains mentioned by @dnmTX was removed on December 23rd (https://github.com/anudeepND/blacklist/commit/1a8f70eef1b26c981f249fd5f566cd1962fe301a) along with other misspelled domains.