PyFunceble: Adblock decoder ignore some portion when decoding
As reported by @dnmTX at https://github.com/Ultimate-Hosts-Blacklist/dev-center/issues/9:
everything with
##[href^=…
are ignored.
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 76 (36 by maintainers)
Commits related to this issue
- Fix issue regarding the decoding of specific lines inside the adblock decoder. This patch partially fix #13 Review: * Of the way we check for URL. Indeed, we know do not care about the used protoc... — committed to funilrys/PyFunceble by funilrys 6 years ago
- Fix false positive extraction of the adblock decoder. This patch fix #13. Reverse: * Of the last patch for the way we check for URL. Introduction: * Of new test cases. * Of the force update f... — committed to funilrys/PyFunceble by funilrys 6 years ago
- Improvement of the adblock decoding. This patch follow #13. Also: * Review of the way we handle the merging in development. — committed to funilrys/PyFunceble by funilrys 6 years ago
- Add more tests for the adblock decoder. The tests were based on the input of @kulfoon at https://github.com/funilrys/PyFunceble/issues/13#issuecomment-619415365 Please take in consideration my respo... — committed to funilrys/PyFunceble by funilrys 4 years ago
- Rewrite AdBlock / Filter List decoder. This patch closes #227. This patch fixes #13. To quote @keczuppp (#13): > [.. ] but it seems you extract way too much in this mode on your own > and it might ... — committed to funilrys/PyFunceble by funilrys 3 years ago
- Fix adblock decoding issue. This patch fixes the error provided by @keczuppp at #13. Contributors: * @keczuppp — committed to funilrys/PyFunceble by funilrys 3 years ago
- Always (explicitly) use the UTF-8 encoding. This patch fixes https://github.com/funilrys/PyFunceble/issues/13#issuecomment-802901412. Contributors: * @keczuppp — committed to PyFunceble/adblock-decoder by funilrys 3 years ago
Hi @jawz101, I’m writing an improvement but we have to admit, it’s impossible to avoid false positive. That’s why whitelisting is more important than blocking.
Now we have to decide between 2 way:
For now, I’m implementing the second way but we may think about the other way in the future or as an extra option.