FreeRTOS-Kernel: [BUG]: Compilation Warning on main branch

Describe the bug

I am currently seeing this issue in the main Branch of FreeRTOS Kernel:

[109/111] Building C object CMakeFiles/JadeDrive.dir/3rdParty/FreeRTOS-Kernel/queue.c.obj
In file included from ../3rdParty/FreeRTOS-Kernel/include/FreeRTOS.h:64,
                 from ../3rdParty/FreeRTOS-Kernel/queue.c:37:
../3rdParty/FreeRTOS-Kernel/portable/ThirdParty/GCC/RP2040/include/portmacro.h: In function 'vPortRecursiveLock':
../3rdParty/FreeRTOS-Kernel/portable/ThirdParty/GCC/RP2040/include/portmacro.h:197:32: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
  197 |         configASSERT(ulLockNum >= 0 && ulLockNum < portRTOS_SPINLOCK_COUNT );


Since, my workspace treats all Warnings as errors this small issue is creating the builds issue. This issue is seen on main and smp branch of FreeRTOS-Kernel

Target RPi Pico

Host

  • Host OS: Ubuntu
  • Compiler: GCC: 9.2.1

To Reproduce Build the FreeRTOS Kernel for RPI Pico with -Wall -Wextra -Weverything flags on

Expected behavior The warning shall not be produced. A clean build

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 19 (19 by maintainers)

Most upvoted comments

I tested the current main branch and build the code. It works!. Thanks The issue can be closed now.

Hi @pranjalchanda08, Thanks for your contribution! That really helps! #736 is created to fix the following warnings first. After merging this, I’ll create another PR on FreeRTOS repo to add this into CI flow.

Thanks @ActoryOu,

For all the spontaneous and continuous support.

Really appreciate your quick response!

Regards,

Hi @pranjalchanda08, Thanks for your contribution! That really helps! #736 is created to fix the following warnings first. After merging this, I’ll create another PR on FreeRTOS repo to add this into CI flow.

@pranjalchanda08,

That would be super helpful. Please help to use PicoWarn2 branch.

Thanks a lot!

Hi @pranjalchanda08, Sure. I’ll fix it with CI change.

Hi @pranjalchanda08, Thanks for bringing this into our attention.

I’ve created a PR #732 to fix this compile warning. Will close this issue when it gets merged.

Thanks.