poudriere: `.building` folder not getting renamed after a bulk build, something to do with `PKG_REPO_SIGNING_KEY` setting

Prerequisites

• Have you checked for an existing issue describing your problem?
• Are you running the latest version?
• Is your ports tree recent?
• Is your FreeBSD Host on a supported release?

Describe the bug

After poudriere bulk finishes, /usr/local/poudriere/data/packages/amd64-13-0-default/.building does not get renamed to the expected .real_<timestamp>, and no error messages are emitted. It has something to do with the PKG_REPO_SIGNING_KEY setting.

How to reproduce

Steps to reproduce the behavior:

1. Run poudriere bulk as typical, all packages build, no errors are emitted.
2. Look in /usr/local/poudriere/data/packages/amd64-13-0-default/ folder, note what’s there and not.

Expected behavior

I expect the .building folder to no longer be present, but it is. I discovered that if I comment out my PKG_REPO_SIGNING_KEY setting, then all is well. and/or I expect some error message to be emitted.

Hopefully you can repro by setting PKG_REPO_SIGNING_KEY to something bad, like pointing it to a random file. I suspect there’s some missing error checking when/if signing fails.

I’m not actually sure yet what it doesn’t like about my own privkey.pem. The path is correct. I tried chmod 777 but that didn’t help either.

Environment

• FreeBSD 13.0-RELEASE-p6
• Poudriere Version 3.3.7_1