httpx-oauth: NotImplementedError - get_id_email

First at all, thanks for the new release!! Currently for the new release, the OAuth route, calls an methods that’s not implemented yet, causing an exception NotImplementedError(). Probably would be nice to not call it until the method is implemented?

@router.get("/callback", name=f"{oauth_client.name}-callback")
    async def callback(
        request: Request,
        response: Response,
        access_token_state=Depends(oauth2_authorize_callback),
    ):
        token, state = access_token_state
        account_id, account_email = await oauth_client.get_id_email(
            token["access_token"]
        )

fastapi-users: 1.0.0 fastapi: 0.54.2

About this issue

Original URL
State: open
Created 4 years ago
Comments: 17 (8 by maintainers)

Most upvoted comments

Sorry @martincolladofab for not having replied earlier. Thank you for the detailed information. What bugs me is that GitLab doesn’t seem to send the expires_in/expires_at property, which is not what their documentation states. And clearly, I don’t want to go in the JWT parsing path.

When I have a bit more time, I’ll make tests with hosted GitLab to see what’s going on.

frankie567 on Jun 2, 2020

Actually, what stopped to me was this: (I started with authlib and later on I changed it by httpx-oauth)

Hi @martincolladofab! I deliberately put authlib aside because of its license : https://authlib.org/plans You cannot use it for free for commercial projects, which is a totally no-go for me.

That’s why I created httpx-oauth which is a simple and pure async OAuth client.

https://github.com/frankie567/fastapi-users/issues/68#issuecomment-632643974

martincolladodev on May 31, 2020