done: done doesn't work on KDE Neon/Ubuntu 18.04

Running __done_get_focused_window_id currently returns this:

$ __done_get_focused_window_id
usage:  xprop [-options ...] [[format [dformat]] atom] ...

where options include:
    -grammar                       print out full grammar for command line
    -display host:dpy              the X server to contact
    -id id                         resource id of window to examine
    -name name                     name of window to examine
    -font name                     name of font to examine
    -remove propname               remove a property
    -set propname value            set a property to a given value
    -root                          examine the root window
    -len n                         display at most n bytes of any property
    -notype                        do not display the type field
    -fs filename                   where to look for formats for properties
    -frame                         don't ignore window manager frames
    -f propname format [dformat]   formats to use for property of given name
    -spy                           examine window properties forever

It is the results of running xprop -version 2>&1 >/dev/null at done.fish#L33. There is no option -version in KDE Neon’s (which is Ubuntu 18.04-based) xprop. Commenting out that line makes it work well.

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 17 (14 by maintainers)

Most upvoted comments

Fixed in v1.14.5, thank you @jriddy and @ammgws

franciscolourenco on Apr 11, 2020

@lephuongbg the version you linked to has -help as an option in the manpage. Any idea why it’s telling you it’s an invalid option?

I assumed it is an invalid option due to its return code. Re-checked and in the man page it does list -help as an option. So xprop -help seems to fail due to other reason.

This is a bug in xprop. The man page suggests -help as an option, but the program itself returns an error code when you run that. I’ll looking for the repo to report that to, and i’ll post the link to the relevant issue when i make that report.

In the time being…I think i’ve found a fix, i’ll submit a PR

jriddy on Apr 11, 2020

Please re-open this issue.

xprop -help 2>&1 > /dev/null actually returns 1 because -help is an invalid option.

We can use xprop -grammar 2>&1 > /dev/null instead.

lephuongbg on Apr 9, 2020