foundation-sites: [SCSS 6.2] possible bug, default $foundation-palette colors overriding old variables even if @include add-foundation-colors; is not included in _settings.scss
I was wondering why something calling $alert-color had suddenly turned salmon color (I hadn’t added in $foundation-palette + @include add-foundation-colors) yet in my 6.2 migration.
An easy override, but I’d rather fix the issue, so I copied the $foundation-palette map from the default _settings.scss and edited the values inside. The element was colored as originally intended - however commenting / uncommenting @include add-foundation-colors had no (immediately noticeable) difference.
If I understand correctly, $foundation-palette is supposed to be optional and we can continue to use traditional variables, but at the moment (I assume) it’s !default values are overriding the old traditional variables. It’d also be nice to have some explanation of the implications of using the SASS map (I assume for autogenerating classes? hence why we’d want some things inside it and some more tertiary colors outside of it) - maybe that’s up somewhere and I just haven’t stumbled across it.
About this issue
- Original URL
- State: closed
- Created 8 years ago
- Comments: 15 (15 by maintainers)
@andycochran could we use the get-color function everywhere to make it a bit easier?