salesforcedx-vscode: Cannot read property 'fspath' of undefined --> when using a Keyboard shortcut to deploy Salesforce file

One of my colleagues found a good way to do this:

Output: hit “cmd+shift+b” (in MacOS), it will do

1. save 2)sfdx deploy current file

Steps

1. Go to “Terminal” in VSC top menu
2. Click “Configure tasks…”
3. New a task from a template
4. Copy paste code below to “tasks.json” and save
5. Now “cmd+shift+b” (the default build hotkey) will do what we want.

{
  // See https://go.microsoft.com/fwlink/?LinkId=733558
  // for the documentation about the tasks.json format
  "version": "2.0.0",
	"tasks": [
	{
	"label": "ssave",
	"type": "shell",
	"command": "sfdx force:source:deploy -p ${file}",
	"group": {
	"kind": "build",
	"isDefault": true
	},
	"problemMatcher": []
	}
  ]
}

Save on deploy is going out in our next release.

@ntotten @lcampos Dug around a bit and saw the error was caused by line 49 in https://github.com/forcedotcom/salesforcedx-vscode/blob/develop/packages/salesforcedx-vscode-core/src/commands/forceSourceRetrieve.ts

Changing the constructor from this,

public constructor(explorerPath: any) {
    this.explorerPath = explorerPath.fsPath;
}

to,

public constructor(explorerPath: any) {
    this.explorerPath = typeof explorerPath !== "undefined" ? explorerPath.fsPath : vscode.window.activeTextEditor.document.uri.fsPath;
}

seems to do the trick.

Would like to know any possible downsides to this fix. Thanks.

Hi all - we’re taking a look at “Cannot read property ‘fsPath’ of undefined” with a new issue #3656 - feel free to add any additional details there. (Deploy on save issues we’re tracking on #3655 and are currently working on a fix for that one.) Thanks for your comments and patience!

Passed 4 months and the “bug” exist yet, @Xixiao007 gave the perfect solution for this problem: https://github.com/forcedotcom/salesforcedx-vscode/issues/662#issuecomment-439354751

Why SF don’t update it yet 😦?

@Anaatoole fix did not work for me. Still broken.

For me just reload twice VS Code worked.

Wow that worked for me! Thank you @Anaatoole!

This issue appears to be broken again. I updated VSCode today and it now gives me the same error. Was working previously.

push/deploy on save is not a viable alternative for many, including myself. Many plugins can cause the file to save (such as editorconfig), plus many people have a habit of frequently saving their code, way before its compilable and ready to push to an org.

Deploy on save is a good feature for those that want it, but it is not really a reliable alternative to having a shortcut that ONLY deploys, when the developer is ready.

Just my opinion of course!

@randi274 I am on 53.4.2 and was on that version when I posted earlier today, but it was fixed only after I updated the CLI today. Since it appears to be fixed, it’s probably fine but it appears to not be perfect based on this. I updated the CLI from 122 to 124. Don’t remember the rest of the version numbers, but that’s all that fixed it for me.

For me just reload twice VS Code worked.

I started getting this error today too. Yesterday it worked fine. I had to disable deploy on save and right click on a file to deploy.

+1 on this issue. I can see a pull request waiting to be approved, hopefully it will be released soon so we can optimise our workflows. Huge thanks to the devs who are working on the fix.

@lcampos Hiya, just a quick follow up re the tooling API. While I get that it doesn’t support all metadata types, you should definitely consider enabling it just for those types that it does. Though I’m sure you have… You guys know what you’re doing. (I’m kind of an idiot…)

Anyhoo… I have recently installed the SalesforceDX Code Companion extension. It uses an sfdx plugin he built which provides new commands to save/retrieve using the Tooling API, and I’ve gotta say… it’s now all I use (for Apex anyway).

1. It’s super-quick
2. He returns a diff with the option to overwrite

Ctrl-shift-c for the win. Now, I’m happy. I was honestly having a hard time being productive with the deploy to save.

Just my experience…

Anyways, keep up the great work guys!

@JamieBriersSageCom Makes sense, thanks for the explanation. I will reopen for us to implement or to accept a PR.

hi @Xtremefaith, using a keybinding for existing deploy commands won’t work because of limitations on how to define it and the commands depending on a filepath to be provided. We explored the possibility of changing the commands to show a quick-pick option, when no filepath was provided, and then choose the file/folder you wanted to deploy. We discarded that because of how unmanageable it became when working on medium-to-large projects and decided to invest time in releasing the current deploy on save functionality. If this is something you really want I’d suggest opening a feature request (a new issue) for it.

As to how deploy on save works, it deploys only the file that you save. E.g. if you are modifying an apex class and save it, it will wait for a few seconds to see if you’re done editing it and will then deploy the file.