fonttools: XML format does not retain LookupType for lookups with no subtables

Eg, we currently can only encode:

<Lookup index="1" empty="1"/>

the LookupType is implied by the type of the subtables. If there’s no subtable, we don’t record lookup type and roundtripping changes it (probably to zero).

About this issue

Original URL
State: closed
Created 8 years ago
Comments: 15 (13 by maintainers)

Commits related to this issue

Don't ignore Lookup.LookupType A while back I changed code such that Lookup.LookupType is written as a comment in XML, and ignored when compiling. The LookupType from type of actual subtables in a l... — committed to fonttools/fonttools by behdad 8 years ago

Most upvoted comments

Easy everyone… First keep it simple. Second, having to write ChangeLog brings back ancient memories. Either we should autogenerate ChangeLog from git log (I do that in HarfBuzz and other projects), or, a high-level summary of big and user-facing changes should be put in NEWS, in which case not every commit should touch it.

My bikeshed-detector has been buzzing more frequently than I like recently 😉.

behdad on Jan 5, 2017