fontbakery: Check 028: Check fails when OFL.txt is present
Observed behaviour
Run fontbakery from the root directory of a font repo containing an OFL.txt file and this test will fail.
Expected behaviour
If valid OFL.txt file is in repo root directory, the test should pass.
Resources and exact process needed to replicate
Version: 0.5.2.dev18+gcff658dd
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 24 (3 by maintainers)
Commits related to this issue
- fix check/028 & add a test for family_directory condition Now a license file on the current working directory is properly detected. (issue #2087) — committed to felipesanches/fontbakery by felipesanches 6 years ago
- fix check/028 & add a test for family_directory condition Now a license file on the current working directory is properly detected. (issue #2087) — committed to fonttools/fontbakery by felipesanches 6 years ago
- search for a license file on the git-repo rootdir if the font project is in a repo. (issue #2087) — committed to felipesanches/fontbakery by felipesanches 6 years ago
- search for a license file on the git-repo rootdir if the font project is in a repo. (issue #2087) This also changes the checkrunner-based example test in order to avoid the detection of Fontbakery's... — committed to felipesanches/fontbakery by felipesanches 6 years ago
- search for a license file on the git-repo rootdir if the font project is in a repo. (issue #2087) This also changes the checkrunner-based example test in order to avoid the detection of Fontbakery's... — committed to fonttools/fontbakery by felipesanches 6 years ago
From an email earlier today.
Checking pwd, same path as each font file, if they are not in pwd and deduplicated, and git rev-parse --show-toplevel (if it returns something) seems sufficient to me
Can we start by only accepting the first
..if the current dir is calledfonts?