fluent-bit: Release v1.8.0 DEB-package libfluent-bit.so and td-agent-bit.service missing
Bug Report
Describe the bug
We’re using your apt repository for ubuntu. Today I installed on a new machine (18.04) td-agent-bit and was curious why no systemd service was created. I found out that version 1.8.0 was released. So i made made a comparison with the old deb-package from version 1.7.9 which i knew worked. I discovered that the files (libfluent-bit.so and td-agent-bit.service) which would be normally created in /lib/td-agent-bit and respectively /lib/systemd/system were missing. Instead they’re now in /opt located.
To Reproduce
- get deb packages from both versions
- extract content from the packages
$ mkdir 180 && dpkg-deb -R td-agent-bit_1.8.0_amd64.deb 180/
$ mkdir 179 && dpkg-deb -R td-agent-bit_1.7.9_amd64.deb 179/
- difference shown simply with a find
$ find 180/
180/
180/etc
180/etc/td-agent-bit
180/etc/td-agent-bit/parsers.conf
180/etc/td-agent-bit/td-agent-bit.conf
180/etc/td-agent-bit/plugins.conf
180/DEBIAN
180/DEBIAN/prerm
180/DEBIAN/md5sums
180/DEBIAN/control
180/DEBIAN/postinst
180/opt
180/opt/td-agent-bit
180/opt/td-agent-bit/bin
180/opt/td-agent-bit/bin/td-agent-bit
180/opt/td-agent-bit/lib
180/opt/td-agent-bit/lib/libfluent-bit.so
180/opt/td-agent-bit/lib/systemd
180/opt/td-agent-bit/lib/systemd/system
180/opt/td-agent-bit/lib/systemd/system/td-agent-bit.service
$ find 179/
179/
179/etc
179/etc/td-agent-bit
179/etc/td-agent-bit/parsers.conf
179/etc/td-agent-bit/td-agent-bit.conf
179/etc/td-agent-bit/plugins.conf
179/DEBIAN
179/DEBIAN/conffiles
179/DEBIAN/md5sums
179/DEBIAN/control
179/opt
179/opt/td-agent-bit
179/opt/td-agent-bit/bin
179/opt/td-agent-bit/bin/td-agent-bit
179/lib
179/lib/td-agent-bit
179/lib/td-agent-bit/libfluent-bit.so
179/lib/systemd
179/lib/systemd/system
179/lib/systemd/system/td-agent-bit.service
Expected behavior
I don’t know if you intended to create the files in the new release under /opt and wanted to place them afterwards with a POSTINST-script in the proper dirs or some bug has accidentally put them into opt. Because in v1.8.0 there is a postinst script (s. below) which echoes /opt/td-agent-bit/lib into /etc/ld.so.conf.d/libfluent-bit.conf which wasnt there in v1.7.9.
In any case something is wrong with this deb in your latest release.
$ cat 180/DEBIAN/postinst
mkdir -p /etc/ld.so.conf.d
echo "/opt/td-agent-bit/lib" > /etc/ld.so.conf.d/libfluent-bit.conf
ldconfig
Your Environment
- Version used: 1.8.0 and 1.7.9
- Configuration: n/a
- Server type and version: Ubuntu 18.04.5 LTS amd64
- Operating System and version: Ubuntu 18.04.5 LTS amd64
- Filters and plugins: n/a
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Reactions: 6
- Comments: 26 (8 by maintainers)
Commits related to this issue
- build: set FLB_RUN_LDCONFIG to No as default to fix #3742 Signed-off-by: Eduardo Silva <edsiper@gmail.com> — committed to fluent/fluent-bit by edsiper 3 years ago
- build: set FLB_RUN_LDCONFIG to No as default to fix #3742 Signed-off-by: Eduardo Silva <edsiper@gmail.com> — committed to fluent/fluent-bit by edsiper 3 years ago
- build: set FLB_RUN_LDCONFIG to No as default to fix #3742 Signed-off-by: Eduardo Silva <edsiper@gmail.com> Signed-off-by: Eduardo Silva <edsiper@gmail.com> — committed to fluent/fluent-bit by edsiper 3 years ago
- build: set FLB_RUN_LDCONFIG to No as default to fix #3742 Signed-off-by: Eduardo Silva <edsiper@gmail.com> Signed-off-by: Eduardo Silva <edsiper@gmail.com> — committed to fluent/fluent-bit by edsiper 3 years ago
we will have to release v1.8.1 to fix the build problem. There is some complexity by rebuilding packages with specific package versioning only… WIP
we are taking a look at this
@edsiper As per @ruilapa its still broken for RHEL/amzn2. Can you please revert again? I would really recommend create staging yum channel as trowing “POC” RPMS into Production one is not a good practice, considering its breaking a lot of folks. We usually don’t pin versions when installing (really at some point you have to trust people to do right thing) So we basically do
yum install td-agent-bit -yand it breaks us each time you try some experimental code.And is it me or you are purging old RPMS too? O_o
On top of this, it overwrites the previous config file, without asking, and without making a backup.
I’m still unable to install on:
Looks much better now. I did notice however that systemd complained about unit files being changed on disk without a reload. Maybe a systemd daemon reload is missing in the post install script? Also the service wasn’t restarted after upgrade, so without a manual restart you’ll still be running the previous version.