react-scroll: Setting Link active state seems to be broken in v1.6.4

I’ve noticed that after upgrading, the active state of a Link never gets set. onSetActive prop also never gets called. I am guessing it’s related to the recent refactors done on Helpers.js

Downgrading to v1.5.5 works but it seems like in general there is something off with the state management of the active links. For instance in v1.5.5 I’ve found refreshing the page makes active state malfunction similar to what’s mentioned in #193 and #124. It looks like spy/active state is a recurring issue: #250, #125, #29

About this issue

  • Original URL
  • State: closed
  • Created 7 years ago
  • Comments: 20 (9 by maintainers)

Most upvoted comments

I’m not gonna close it, I will lable it as a bug. And will obviously try to solve it before the week ends, but my time is limited atm.

Gonna look into this today, might be solved by the end of the day.