firebase-ios-sdk: FIRESTORE INTERNAL ASSERTION FAILED: Trying to compare documents on fields that don't exist. (expected value1.has_value() && value2.has_value())

@igorvoytovich Thanks for the info. That gives a pretty strong indicator that the crash is fixed. I’ll wait for @sspogra to reply to see if the crash resolution is confirmed.

@igorvoytovich Thanks for the updated stack trace. My guess is that my fix #9550 fixed the original crash, and now it’s gotten past the point where it was previously crashing and is now crashing in a different place. Since it’s not clear, I’d like to treat it as a new issue. Would you mind opening a new issue with this new stack trace? Even if it’s related, it’s going to require its own investigation.

Also, you mentioned in your older comment (https://github.com/firebase/firebase-ios-sdk/issues/9258#issuecomment-1024736997) that you were getting “hundreds” of reports of the old crash. Do you still get any reports of the old stack trace after upgrading to 8.15.0? Or are all of your crashes this “new” stack trace since upgrading to 8.15.0?

@dconeybe App still not updated on app store with new firebase version. For now you can close this issue, I will comment here when my app was live on store.

@dconeybe I will check this only when app release to app store. Our app will be release within 10 days. After that i can provide you feedback.

Hello @dconeybe Updated stack trace

Fatal Exception: NSInternalInconsistencyException
FIRESTORE INTERNAL ASSERTION FAILED: Trying to compare documents on fields that don't exist; field_path=__name__, lhs=users/16451, rhs=users/16451, value1.has_value()=false, value2.has_value()=false
0
CoreFoundation
__exceptionPreprocess
2
Foundation
-[NSMutableDictionary(NSMutableDictionary) initWithContentsOfFile:]
3
FirebaseFirestore
exception_apple.mm - Line 59
firebase::firestore::util::ObjcThrowHandler(firebase::firestore::util::ExceptionType, char const*, char const*, int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 59
4
FirebaseFirestore
exception.cc - Line 97
firebase::firestore::util::Throw(firebase::firestore::util::ExceptionType, char const*, char const*, int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 97
5
FirebaseFirestore
hard_assert.cc - Line 42
firebase::firestore::util::internal::FailAssertion(char const*, char const*, int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*) + 42
6
FirebaseFirestore
order_by.cc - Line 62
firebase::firestore::core::OrderBy::Compare(firebase::firestore::model::Document const&, firebase::firestore::model::Document const&) const + 62
7
FirebaseFirestore
query.cc - Line 289
std::__1::__function::__func<firebase::firestore::core::Query::Comparator() const::$_0, std::__1::allocator<firebase::firestore::core::Query::Comparator() const::$_0>, firebase::firestore::util::ComparisonResult (firebase::firestore::model::Document const&, firebase::firestore::model::Document const&)>::operator()(firebase::firestore::model::Document const&, firebase::firestore::model::Document const&) + 289
8
FirebaseFirestore
find_if.h - Line 28
firebase::firestore::immutable::impl::ArraySortedMap<firebase::firestore::model::Document, firebase::firestore::util::Empty, firebase::firestore::model::DocumentComparator>::find(firebase::firestore::model::Document const&) const + 28
9
FirebaseFirestore
array_sorted_map.h - Line 216
firebase::firestore::immutable::impl::ArraySortedMap<firebase::firestore::model::Document, firebase::firestore::util::Empty, firebase::firestore::model::DocumentComparator>::erase(firebase::firestore::model::Document const&) const + 216
10
FirebaseFirestore
sorted_map.h - Line 371
firebase::firestore::immutable::SortedMap<firebase::firestore::model::Document, firebase::firestore::util::Empty, firebase::firestore::model::DocumentComparator>::erase(firebase::firestore::model::Document const&) const + 371
11
FirebaseFirestore
sorted_set.h - Line 51
firebase::firestore::immutable::SortedSet<firebase::firestore::model::Document, firebase::firestore::model::DocumentComparator>::erase(firebase::firestore::model::Document const&) const + 51
12
FirebaseFirestore
document_set.h - Line 137
firebase::firestore::model::DocumentSet::erase(firebase::firestore::model::DocumentKey const&) const + 137
13
FirebaseFirestore
optional.h - Line 428
firebase::firestore::model::DocumentSet::insert(absl::lts_2020_02_25::optional<firebase::firestore::model::Document> const&) const + 428
14
FirebaseFirestore
view.cc - Line 198
firebase::firestore::core::View::ComputeDocumentChanges(firebase::firestore::immutable::SortedMap<firebase::firestore::model::DocumentKey, firebase::firestore::model::Document, firebase::firestore::util::Comparator<firebase::firestore::model::DocumentKey> > const&, absl::lts_2020_02_25::optional<firebase::firestore::core::ViewDocumentChanges> const&) const + 198
15
FirebaseFirestore
sync_engine.cc - Line 475
firebase::firestore::core::SyncEngine::EmitNewSnapshotsAndNotifyLocalStore(firebase::firestore::immutable::SortedMap<firebase::firestore::model::DocumentKey, firebase::firestore::model::Document, firebase::firestore::util::Comparator<firebase::firestore::model::DocumentKey> > const&, absl::lts_2020_02_25::optional<firebase::firestore::remote::RemoteEvent> const&) + 475
16
FirebaseFirestore
sync_engine.cc - Line 212
firebase::firestore::core::SyncEngine::WriteMutations(std::__1::vector<firebase::firestore::model::Mutation, std::__1::allocator<firebase::firestore::model::Mutation> >&&, std::__1::function<void (firebase::firestore::util::Status)>) + 212
17
FirebaseFirestore
function.h - Line 463
std::__1::__function::__func<firebase::firestore::core::FirestoreClient::WriteMutations(std::__1::vector<firebase::firestore::model::Mutation, std::__1::allocator<firebase::firestore::model::Mutation> >&&, std::__1::function<void (firebase::firestore::util::Status)>)::$_15, std::__1::allocator<firebase::firestore::core::FirestoreClient::WriteMutations(std::__1::vector<firebase::firestore::model::Mutation, std::__1::allocator<firebase::firestore::model::Mutation> >&&, std::__1::function<void (firebase::firestore::util::Status)>)::$_15>, void ()>::operator()() + 463
18
FirebaseFirestore
atomic - Line 997
firebase::firestore::util::AsyncQueue::ExecuteBlocking(std::__1::function<void ()> const&) + 997
19
FirebaseFirestore
function.h - Line 491
firebase::firestore::util::Task::ExecuteAndRelease() + 491
20
libdispatch.dylib
_dispatch_client_callout
25
libsystem_pthread.dylib
start_wqthread

This is the raw stack trace we are seeing on version 8.13.0

NSInternalInconsistencyException: Application threw exception NSInternalInconsistencyException: FIRESTORE INTERNAL ASSERTION FAILED: Trying to compare documents on fields that don't exist; field_path=__name__, lhs=classes/vLp84zTO474mi31RyQLy, rhs=classes/vLp84zTO474mi31RyQLy, value1.has_value()=false, value2.has_value()=false

@sspogra The improvement of the error message has been incorporated into version 8.12.1 of the iOS SDK, released on February 10, 2022. When you get a chance, upgrade your dependency to this new version and provide updated stack traces and error messages.