firebase-android-sdk: App crashes in In-App Messaging card type with empty message body

[REQUIRED] Step 2: Describe your environment

Android Studio version: 3.5.3
Firebase Component: In-App Messaging
Component version: 19.0.2

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

What happened? How can we make the problem occur? This could be a description, log/console output, etc.

Relevant Code:

1. Compose a campaign with Card Type layout
2. Set optional message body to empty
3. App crashes

About this issue

Original URL
State: closed
Created 4 years ago
Reactions: 5
Comments: 18 (9 by maintainers)

Most upvoted comments

Since this has started happening recently without any code change in the app, I am suspecting that something has changed on their backend. Their backend is not sending the data to clients in the expected format which is causing this crash. I think there are two parts to this issue:

Fix the client SDK to handle the non empty string errors
Fix the backend at priority so that no new users are impacted.

mohit92 on Mar 19, 2020

Hey I appreciate the PR but I’m going to be applying a more general fix to all of our proto parsing to remove this entire class of errors rather than just this one error. I’m going to go ahead and close our your PR but I really appreciate you taking the time to come up with a fix.

I’m also closing out this issue as this is now resolved.

JasonAHeron on Mar 19, 2020

Hey folks, this is now fixed. For users who have a cached bad state it seems the best solution (as horrible as this is) is to uninstall and reinstall the app (or clear app data). Going forward I will be fixing the SDK to remove this class of errors in the future. Really sorry about this.

JasonAHeron on Mar 19, 2020

I have a fix rolling out to production now. I’ll let you folks know when this is resolved.

JasonAHeron on Mar 19, 2020