react-final-form: Form can be submitted even with validation errors

The valid/invalid flags are currently based solely on registered fields.

Having thought about this for 24 hours, I think @VladShcherbin might be right. Non-registered field errors should also affect valid/invalid flags and halt submission.

@erikras extra functionality + reduced bundle size 🙂 Maybe you have to reconsider your

I plan on being a little more willing to say, “No, I will not implement your specific feature,” with this library, to minimize its complexity and surface area.

You can add “If it reduces bundle size, it will have a bigger change of being implemented” 😂

LOL, this change actually reduced the size of the bundle.

Published fix in final-form@1.1.0.

Yes. Injecting errors, like we do values into the form render function makes sense.

Published actual fix in final-form v1.2.1.

@erikras I’ve been waiting for this fix for so long, after I found this in redux-form the first thing I check in forms packages is this one.

Thank you ❤️

Having thought about this for a few hours, it seems like you could accomplish what you want with this:

const validate = values => {
  const errors = {}
  // do validation
  return errors
}

const onSubmit = async values => {
  const errors = validate(values)
  if(Object.keys(errors).length) {
    return errors
  }
  // actually submit
  ajax.post('/blahblah', values)
}

You could reuse your record-level validation function to return submission errors, thus halting the submit.

Reasonable? Unreasonable?