filament: Sorting icon in table missing
Package
filament/tables
Package Version
v2.15.44
Laravel Version
v8.83.23
Livewire Version
v2.10.7
PHP Version
PHP 8.0.22
Problem description
sort icon on table did not appear, but sorting is still working, i seen this PR merge https://github.com/filamentphp/filament/pull/3801, and try to revert this on my vendor and its back to normal
i get this error on console tab
Uncaught ReferenceError: $isSortColumn is not defined
at eval (eval at <anonymous> (module.esm.js:471:14), <anonymous>:3:32)
at module.esm.js:489:21
at V (module.esm.js:409:12)
at module.esm.js:2623:17
at n (module.esm.js:1609:16)
at Object.effect (module.esm.js:1584:5)
at r (module.esm.js:48:33)
at module.esm.js:64:27
at Function.<anonymous> (module.esm.js:2623:3)
at n (module.esm.js:561:7)
Expected behavior
sort icon will still working
Steps to reproduce
make sure you sorting on table is working and has it icon, then upgrade to a latest table version, take a look on icon will dis-appear and check the browser console tab
Reproduction repository
https://github.com/lloricode/laravel-filament-issue/tree/table-sort-icon
Relevant log output
module.esm.js:420 Uncaught ReferenceError: $isSortColumn is not defined
at eval (eval at <anonymous> (module.esm.js:471:14), <anonymous>:3:32)
at module.esm.js:489:21
at V (module.esm.js:409:12)
at module.esm.js:2623:17
at n (module.esm.js:1609:16)
at Object.effect (module.esm.js:1584:5)
at r (module.esm.js:48:33)
at module.esm.js:64:27
at Function.<anonymous> (module.esm.js:2623:3)
at n (module.esm.js:561:7)
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 26 (17 by maintainers)
Commits related to this issue
- reproduce issue for https://github.com/filamentphp/filament/issues/3861 Signed-off-by: Lloric Mayuga Garcia <lloricode@gmail.com> — committed to lloricode/laravel-filament-issue by lloricode 2 years ago
confirmed already with with v2.16.2
thanks @danharrin 💯
I’ve checked with your reproduction repository, @lloricode. Updating Filament to the latest version does fix the issue.
@danharrin, your fix did work then.
yes, possible tomorrow will check this,
@lloricode, could you confirm if this is still an issue in the latest Filament version or it has been resolved?
Yes, there is some reason why Blade components are not being compiled properly in your setup
I’ve seen this sort of issue before and I cant remember the fix.