fastlane: Wrong screen sizes on recent iphones

New Issue Checklist

Issue Description

This bug seems to affect only most recent iPhones starting with iPhone X all the way through iPhone XS Max. The images are fine, but all sizes are totally off which of course means that submission to the app store is a no-go.

Fastlane vs simulator/required image sizes: iPhone X: 1125 × 1996 - (1125 × 2436) iPhone Xʀ: 828 × 1469 - (828 × 1792) iPhone Xs Max: 1242 × 2204 - (1242 × 2688)

Additionally fastlane has difficulties with the simulator names. Instead of separating rows by devices, as is typically the case, it generates one gigantic row for anything that includes “iPhone X” (4 different devices).

Command executed
Complete output when running fastlane, including the stack trace and command used
fastlane screenshots

Environment

Stack

Key Value
OS 10.14.5
Ruby 2.5.1
Bundler? false
Git git version 2.20.1 (Apple Git-117)
Installation Source /usr/local/bin/fastlane
Host Mac OS X 10.14.5 (18F132)
Ruby Lib Dir /usr/local/Cellar/ruby/2.5.1/lib
OpenSSL Version OpenSSL 1.0.2o 27 Mar 2018
Is contained false
Is homebrew false
Is installed via Fabric.app false
Xcode Path /Applications/Xcode.app/Contents/Developer/
Xcode Version 10.2.1

System Locale

Variable Value
LANG en_US.UTF-8 ✅
LC_ALL en_US.UTF-8 ✅
LANGUAGE

fastlane files:

`./fastlane/Fastfile` 
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:ios)

platform :ios do
  desc "Generate new localized screenshots"
  lane :screenshots do
    capture_screenshots(scheme: "XXX")
  end
end
`./fastlane/Appfile` 
app_identifier("xxx.xxx.xxxx") # The bundle identifier of your app
# apple_id("[[APPLE_ID]]") # Your Apple email address


# For more information about the Appfile, see:
#     https://docs.fastlane.tools/advanced/#appfile

fastlane gems

Gem Version Update-Status
fastlane 2.126.0 ✅ Up-To-Date

Loaded fastlane plugins:

No plugins Loaded

Loaded gems
Gem Version
did_you_mean 1.2.1
slack-notifier 2.3.2
atomos 0.1.3
CFPropertyList 3.0.0
claide 1.0.2
colored2 3.1.2
nanaimo 0.2.6
xcodeproj 1.9.0
rouge 2.0.7
xcpretty 0.3.0
terminal-notifier 2.0.0
terminal-table 1.8.0
plist 3.5.0
public_suffix 2.0.5
addressable 2.6.0
multipart-post 2.0.0
word_wrap 1.0.0
babosa 1.0.2
colored 1.2
highline 1.7.10
commander-fastlane 4.4.6
excon 0.64.0
faraday 0.15.4
unf_ext 0.0.7.6
unf 0.1.4
domain_name 0.5.20180417
http-cookie 1.0.3
faraday-cookie_jar 0.0.6
fastimage 2.1.5
gh_inspector 1.1.3
mini_magick 4.5.1
multi_xml 0.6.0
security 0.1.3
xcpretty-travis-formatter 1.0.0
dotenv 2.7.2
faraday_middleware 0.13.1
naturally 2.2.0
simctl 1.6.5
jwt 2.1.0
uber 0.1.0
declarative 0.0.10
declarative-option 0.1.0
representable 3.0.4
retriable 3.1.2
mime-types-data 3.2019.0331
mime-types 3.2.2
multi_json 1.13.1
signet 0.11.0
memoist 0.16.0
os 1.0.1
googleauth 0.6.7
httpclient 2.8.3
google-api-client 0.23.9
google-cloud-env 1.0.5
google-cloud-core 1.3.0
digest-crc 0.4.1
google-cloud-storage 1.16.0
emoji_regex 1.0.1
unicode-display_width 1.6.0
tty-screen 0.7.0
tty-cursor 0.7.0
tty-spinner 0.9.1
json 2.2.0
rubyzip 1.2.3
bundler 2.0.1
openssl 2.1.0
date 1.0.0
fileutils 1.0.2
mini_portile2 2.3.0
nokogiri 1.8.2
ipaddr 1.2.0
psych 3.0.2

generated on: 2019-06-26

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Comments: 18 (11 by maintainers)

Most upvoted comments

Looking at my setup, I found that for iOS 12.0-12.1 Xcode named the simulator iPhone XS Max, while for 12.2 it’s named iPhone Xs Max. Same on both my computers.

+1
claesjacobsson on Jun 28, 2019

As a note, the reported screen sizes were generated with an Objective-c based project. I tested a simple Swift-based project and it produced the correct screen sizes. The bunching of all devices with the string “iPhone X” in their name into the same row of the generated html file occurs in both projects and seems to be a secondary issue.

+1
ajgr on Jun 26, 2019

Here is the new output:

✅ fastlane environment ✅

Stack

Key Value
OS 10.14.5
Ruby 2.5.1
Bundler? false
Git git version 2.20.1 (Apple Git-117)
Installation Source /usr/local/bin/fastlane
Host Mac OS X 10.14.5 (18F132)
Ruby Lib Dir /usr/local/Cellar/ruby/2.5.1/lib
OpenSSL Version OpenSSL 1.0.2o 27 Mar 2018
Is contained false
Is homebrew false
Is installed via Fabric.app false
Xcode Path /Applications/Xcode.app/Contents/Developer/
Xcode Version 10.2.1

System Locale

Variable Value
LANG en_US.UTF-8 ✅
LC_ALL en_US.UTF-8 ✅
LANGUAGE

fastlane files:

`./fastlane/Fastfile` 
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:ios)

platform :ios do
  desc "Generate new localized screenshots"
  lane :screenshots do
    capture_screenshots(scheme: "app_title")
  end
end
`./fastlane/Appfile` 
app_identifier("com.example.app_title") # The bundle identifier of your app
# apple_id("[[APPLE_ID]]") # Your Apple email address


# For more information about the Appfile, see:
#     https://docs.fastlane.tools/advanced/#appfile

fastlane gems

Gem Version Update-Status
fastlane 2.126.0 ✅ Up-To-Date

Loaded fastlane plugins:

No plugins Loaded

Loaded gems
Gem Version
did_you_mean 1.2.1
slack-notifier 2.3.2
atomos 0.1.3
CFPropertyList 3.0.0
claide 1.0.2
colored2 3.1.2
nanaimo 0.2.6
xcodeproj 1.9.0
rouge 2.0.7
xcpretty 0.3.0
terminal-notifier 2.0.0
terminal-table 1.8.0
plist 3.5.0
public_suffix 2.0.5
addressable 2.6.0
multipart-post 2.0.0
word_wrap 1.0.0
babosa 1.0.2
colored 1.2
highline 1.7.10
commander-fastlane 4.4.6
excon 0.64.0
faraday 0.15.4
unf_ext 0.0.7.6
unf 0.1.4
domain_name 0.5.20180417
http-cookie 1.0.3
faraday-cookie_jar 0.0.6
fastimage 2.1.5
gh_inspector 1.1.3
mini_magick 4.5.1
multi_xml 0.6.0
security 0.1.3
xcpretty-travis-formatter 1.0.0
dotenv 2.7.2
faraday_middleware 0.13.1
naturally 2.2.0
simctl 1.6.5
jwt 2.1.0
uber 0.1.0
declarative 0.0.10
declarative-option 0.1.0
representable 3.0.4
retriable 3.1.2
mime-types-data 3.2019.0331
mime-types 3.2.2
multi_json 1.13.1
signet 0.11.0
memoist 0.16.0
os 1.0.1
googleauth 0.6.7
httpclient 2.8.3
google-api-client 0.23.9
google-cloud-env 1.0.5
google-cloud-core 1.3.0
digest-crc 0.4.1
google-cloud-storage 1.16.0
emoji_regex 1.0.1
unicode-display_width 1.6.0
tty-screen 0.7.0
tty-cursor 0.7.0
tty-spinner 0.9.1
json 2.2.0
rubyzip 1.2.3
bundler 2.0.1
openssl 2.1.0
date 1.0.0
fileutils 1.0.2
mini_portile2 2.3.0
nokogiri 1.8.2
ipaddr 1.2.0
psych 3.0.2

generated on: 2019-06-26

+1
ajgr on Jun 26, 2019
Read more comments on GitHub
← fastlane: Version overrides do not work on Gradle 7.3+
fastlane: Wrong screengrab shots folder name →