fastlane: Upgrading to 2.95 breaks changelog_from_git_commits

New Regression Checklist

Updated fastlane to the latest version
I read the Contribution Guidelines
I read docs.fastlane.tools
I searched for existing GitHub issues

Regression Information

Breaking version: 2.95.0
Last working version: 2.94.0

Regression Description

Simply put, fails with:

TypeError: [!] no implicit conversion of nil into String

Looks related to #10358 but it’s not happening in match, I’m invoking changelog_from_git_commits.

Complete output when running fastlane, including the stack trace and command used

I can’t share the full output for privacy, but if this is not enough I can share more snippets on request.

TypeError: [!] no implicit conversion of nil into String
  /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.95.0/fastlane/lib/fastlane/actions/changelog_from_git_commits.rb:32:in `chdir'
  /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.95.0/fastlane/lib/fastlane/actions/changelog_from_git_commits.rb:32:in `run'

Environment

### Stack



Key
Value




OS
10.13.4


Ruby
2.3.0


Bundler?
true


Git
git version 2.17.0


Installation Source
/usr/local/bin/fastlane


Host
Mac OS X 10.13.4 (17E202)


Ruby Lib Dir
/usr/local/Cellar/ruby/2.3.0/lib


OpenSSL Version
OpenSSL 1.0.2e 3 Dec 2015


Is contained
false


Is homebrew
false


Is installed via Fabric.app
false


Xcode Path
/Applications/Xcode.app/Contents/Developer/


Xcode Version
9.3



System Locale



Variable
Value





LANG
en_US.UTF-8
✅


LC_ALL
en_US.UTF-8
✅


LANGUAGE

Key	Value
OS	10.13.4
Ruby	2.3.0
Bundler?	true
Git	git version 2.17.0
Installation Source	/usr/local/bin/fastlane
Host	Mac OS X 10.13.4 (17E202)
Ruby Lib Dir	/usr/local/Cellar/ruby/2.3.0/lib
OpenSSL Version	OpenSSL 1.0.2e 3 Dec 2015
Is contained	false
Is homebrew	false
Is installed via Fabric.app	false
Xcode Path	/Applications/Xcode.app/Contents/Developer/
Xcode Version	9.3

Variable	Value
LANG	en_US.UTF-8	✅
LC_ALL	en_US.UTF-8	✅
LANGUAGE

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 20 (15 by maintainers)

Most upvoted comments

@keeshux That’s very interesting. To add to your point, I think that’s how all the actions work. If you call the action using Fastlane::Actions::SomeAction.run() it won’t pick up the default_value. You would need to specify them manually. I remember having this issue with some other lane as well.

I think it’s safe to close the PR as this bug is invalid. @joshdholtz @revolter Please verify and close the issue.

RishabhTayal on May 11, 2018