fastlane: Unknown device type for size iOS-5.8-in fastlane frameit

New Issue Checklist

Issue Description

When running ‘fastlane frameit’ in a directory with iPhone X screenshots (resolution 1125x2436) the device type cannot be found.

Complete output when running fastlane, including the stack trace and command used

INFO [2017-11-06 13:08:24.48]: Framing screenshot ‘./Simulator Screen Shot - iPhone X - 2017-11-06 at 12.35.35.png’ ERROR [2017-11-06 13:08:24.48]: Unknown device type for size iOS-5.8-in for path ‘./Simulator Screen Shot - iPhone X - 2017-11-06 at 12.35.35.png’ ERROR [2017-11-06 13:08:24.49]: Unknown device type for size iOS-5.8-in for path ‘./Simulator Screen Shot - iPhone X - 2017-11-06 at 12.35.35.png’ ERROR [2017-11-06 13:08:24.49]: Unknown device type for size iOS-5.8-in for path ‘./Simulator Screen Shot - iPhone X - 2017-11-06 at 12.35.35.png’ DEBUG [2017-11-06 13:08:24.49]: Looking for Apple true Space Gray and found 0 template(s) ERROR [2017-11-06 13:08:24.49]: Couldn’t find template for screenshot type ‘Apple true Space Gray’ ERROR [2017-11-06 13:08:24.49]: Please run fastlane frameit download_frames to download the latest frames

Environment

✅ fastlane environment ✅

Stack

Key Value
OS 10.12.6
Ruby 2.4.0
Bundler? false
Git git version 2.13.6 (Apple Git-96)
Installation Source ~/.rvm/gems/ruby-2.4.0/bin/fastlane
Host Mac OS X 10.12.6 (16G1036)
Ruby Lib Dir ~/.rvm/rubies/ruby-2.4.0/lib
OpenSSL Version OpenSSL 1.1.0e 16 Feb 2017
Is contained false
Is homebrew false
Is installed via Fabric.app false
Xcode Path /Applications/Xcode.app/Contents/Developer/
Xcode Version 9.1

System Locale

Variable Value
LANG en_US.UTF-8
LC_ALL
LANGUAGE

fastlane files:

No Fastfile found

No Appfile found

fastlane gems

Gem Version Update-Status
fastlane 2.63.0 ✅ Up-To-Date

Loaded fastlane plugins:

No plugins Loaded

Loaded gems
Gem Version
did_you_mean 1.1.0
slack-notifier 1.5.1
CFPropertyList 2.3.5
claide 1.0.2
colored2 3.1.2
nanaimo 0.2.3
xcodeproj 1.5.0
multipart-post 2.0.0
word_wrap 1.0.0
public_suffix 2.0.5
tty-screen 0.5.0
babosa 1.0.2
colored 1.2
highline 1.7.8
commander-fastlane 4.4.5
http-cookie 1.0.3
faraday-cookie_jar 0.0.6
fastimage 2.1.0
gh_inspector 1.0.3
mini_magick 4.5.1
multi_json 1.12.1
multi_xml 0.6.0
rubyzip 1.2.1
security 0.1.3
xcpretty-travis-formatter 0.0.4
bundler 1.14.5
faraday_middleware 0.11.0.1
declarative 0.0.9
declarative-option 0.1.0
representable 3.0.4
addressable 2.5.1
mime-types-data 3.2016.0521
mime-types 3.1
jwt 1.5.6
os 0.9.6
signet 0.7.3
googleauth 0.5.1
httpclient 2.8.3
google-api-client 0.13.6
json 2.1.0
io-console 0.4.6
excon 0.57.0
openssl 2.0.3
plist 3.3.0
faraday 0.12.1
unf 0.1.4
domain_name 0.5.20170404
terminal-table 1.8.0
unicode-display_width 1.3.0

generated on: 2017-11-06

About this issue

  • Original URL
  • State: closed
  • Created 7 years ago
  • Comments: 25 (4 by maintainers)

Most upvoted comments

I was having the same issue and 2.64.0 fixed it. However, now the show_complete_frame setting is being ignored with iPhone X.

Same for me. Any workaround?

@funnel20 Thanks for the comment! I will close this issue since that new issue is opened up 😊

Still an issue in fastlane 2.81.0 iPhone X screenshots is completely ignoring show_complete_frame I’m setting show_complete_frame = false but still getting full frame. Any updates? Thanks

Any update on this?

This is not being fixed, I would like to bring this up.

@taquitos what’st the status of https://github.com/fastlane/fastlane/issues/10805#issuecomment-344842290. Can we find a workaround for iPhone X?

@zocario did you find a workaround to properly frame screenshots?

And for show_complete_frame I have an example of the output with title and background:

iphone x-issues copie_framed

My framefile:

{
  "default": {
       "title": {
	    "font": "./fonts/MuseoSans-700.otf",
      	    "color": "#000000"
        },
        "background": "./background.jpg",
        "padding": 100,
        "show_complete_frame": false
   },
   "data": []
}

Alright, so there are a few things here.

  • frameit isn’t designed to work with App Store… it’s meant for marketing materials, and websites, etc…
  • frameit docs don’t do a good job of pointing that out, in-fact, they are kind misleading (I’ll fix that)
  • show_complete_frame: false only works if you have a title and a background images

I confirm that show_complete_frame is being ignored with iPhone X still have complete frame even if set to false

@banaslee I have not done anything with iPhone X and frameit yet but I will take a look at it and see what is going on 💪