fastlane: [regression] fastlane changed default value for `export_method` in gym
New Issue Checklist
- Updated fastlane to the latest version
- I have read the Contribution Guidelines
Issue Description
After upgrading to 2.47.0 all my build starts failing in Travis-CI with ruby-2.3.0 via RVM saying my certificates are incorrect. Meanwhile all the same config and certificates were totallly fine in 2.46.1. See error log below.
calling gym like this:
scheme = (options[:beta] ? "Release" : "Appstore")
gym(
workspace: 'Project.xcworkspace',
scheme: scheme,
clean: true,
output_directory: ".",
output_name: "Project.ipa",
silent: true,
xcargs: options[:xcargs]
)
Using XCode 8. No XCode 9 installed.
Complete output when running fastlane, including the stack trace and command used
You can use:
--capture_outputas the last commandline argument to get that collected for you
[16:13:04]: ---------------------
[16:13:04]: --- Step: produce ---
[16:13:04]: ---------------------
+----------------+----------------------------------------+
| Summary for produce 2.47.0 |
+----------------+----------------------------------------+
| app_identifier | [secure] |
| app_name | [secure] |
| skip_itc | true |
| username | [secure] |
| sku | [secure] |
| platform | ios |
| language | English |
| skip_devcenter | false |
| team_id | [secure] |
| team_name | [secure] |
| itc_team_id | [secure] |
+----------------+----------------------------------------+
[16:13:06]: [DevCenter] App '[secure]' already exists, nothing to do on the Dev Center
[16:13:07]: --------------------------------------
[16:13:07]: --- Step: increment_version_number ---
[16:13:07]: --------------------------------------
[16:13:12]: $ cd /Users/travis/build/[secure]/iOS/Project && agvtool new-marketing-version 1.1.0
[16:13:13]: ▸ Setting CFBundleShortVersionString of project Project to:
[16:13:13]: ▸ 1.1.0.
[16:13:13]: ▸ Updating CFBundleShortVersionString in Info.plist(s)...
[16:13:13]: ▸ Updated CFBundleShortVersionString in "Project.xcodeproj/../Project/Resources/Info.plist" to 1.1.0
[16:13:13]: ▸ Updated CFBundleShortVersionString in "Project.xcodeproj/../ProjectTests/Info.plist" to 1.1.0
[16:13:13]: ------------------------------------
[16:13:13]: --- Step: increment_build_number ---
[16:13:13]: ------------------------------------
Current version of project Project is:
1.0.0
/Users/travis/build/[secure]/iOS/Project
[16:13:13]: $ cd /Users/travis/build/[secure]/iOS/Project && agvtool new-version -all 1.1.0 && cd -
[16:13:13]: ▸ Setting version of project Project to:
[16:13:13]: ▸ 1.1.0.
[16:13:13]: ▸ Also setting CFBundleVersion key (assuming it exists)
[16:13:14]: ▸ Updating CFBundleVersion in Info.plist(s)...
[16:13:14]: ▸ Updated CFBundleVersion in "Project.xcodeproj/../Project/Resources/Info.plist" to 1.1.0
[16:13:14]: ▸ Updated CFBundleVersion in "Project.xcodeproj/../ProjectTests/Info.plist" to 1.1.0
[16:13:14]: ▸ /Users/travis/build/[secure]/iOS/Project
[16:13:14]: -------------------
[16:13:14]: --- Step: match ---
[16:13:14]: -------------------
+-----------------------+----------------------------------------------+
| Summary for match 2.47.0 |
+-----------------------+----------------------------------------------+
| git_branch | master |
| type | development |
| app_identifier | [secure] |
| force_for_new_devices | true |
| git_url | git@github.com:[secure]/iOS-certificates.git |
| username | [secure] |
| keychain_name | ios-build.keychain |
| keychain_password | ******** |
| readonly | false |
| team_id | [secure] |
| team_name | [secure] |
| verbose | false |
| force | false |
| skip_confirmation | false |
| shallow_clone | false |
| clone_branch_directly | false |
| platform | ios |
+-----------------------+----------------------------------------------+
[16:13:14]: Cloning remote git repo...
[16:13:14]: If cloning the repo takes too long, you can use the `clone_branch_directly` option in match.
[16:16:17]: 🔓 Successfully decrypted certificates repo
[16:16:17]: Verifying that the certificate and profile are still valid on the Dev Portal...
[16:16:18]: Installing certificate...
security: SecKeychainSearchCopyNext: The specified item could not be found in the keychain.
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1062 100 1062 0 0 2587 0 --:--:-- --:--:-- --:--:-- 2583
[16:16:19]: There are no local code signing identities found.
You can run `security find-identity -v -p codesigning` to get this output.
This Stack Overflow thread has more information: https://stackoverflow.com/q/35390072/774.
(Check in Keychain Access for an expired WWDR certificate: https://stackoverflow.com/a/35409835/774 has more info.)
+-------------------+------------------------------------------+
| Installed Certificate |
+-------------------+------------------------------------------+
| User ID | [secure] |
| Common Name | iPhone Developer: Travis CI ([secure]) |
| Organisation Unit | [secure] |
| Organisation | [secure] |
| Country | US |
| Start Datetime | Apr 10 20:57:30 2017 GMT |
| End Datetime | Apr 10 20:57:30 2018 GMT |
+-------------------+------------------------------------------+
[16:16:21]: Installing provisioning profile...
+---------------------+----------------------------------------------------------------------+---------------------------------------------------------------------------------------------------------------+
| Installed Provisioning Profile |
+---------------------+----------------------------------------------------------------------+---------------------------------------------------------------------------------------------------------------+
| Parameter | Environment Variable | Value |
+---------------------+----------------------------------------------------------------------+---------------------------------------------------------------------------------------------------------------+
| App Identifier | | [secure] |
| Type | | development |
| Platform | | ios |
| Profile UUID | sigh_[secure]_development | 9c59b895-7d59-435e-b55e-e846183cd078 |
| Profile Name | sigh_[secure]_development_profile-name | match Development [secure] |
| Profile Path | sigh_[secure]_development_profile-path | /Users/travis/Library/MobileDevice/Provisioning Profiles/9c59b895-7d59-435e-b55e-e846183cd078.mobileprovision |
| Development Team ID | sigh_[secure]_development_team-id | [secure] |
+---------------------+----------------------------------------------------------------------+---------------------------------------------------------------------------------------------------------------+
[16:16:22]: All required keys, certificates and provisioning profiles are installed 🙌
[16:16:22]: Setting Provisioning Profile type to 'development'
[16:16:22]: -------------------
[16:16:22]: --- Step: is_ci ---
[16:16:22]: -------------------
[16:16:22]: fixing keychain for sierra
[16:16:22]: --------------------------------------------------------------------
[16:16:22]: Step: security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k [secure] ios-build.keychain0m
[16:16:22]: --------------------------------------------------------------------
[16:16:22]: $ security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k [secure] ios-build.keychain
[16:16:22]: ▸ keychain: "/Users/travis/Library/Keychains/ios-build.keychain-db"
[16:16:22]: ▸ version: 512
[16:16:22]: ▸ class: 0x00000010
[16:16:22]: ▸ attributes:
[16:16:22]: ▸ 0x00000000 <uint32>=0x00000010
[16:16:22]: ▸ 0x00000001 <blob>="Imported Private Key"
[16:16:22]: ▸ 0x00000002 <blob>=<NULL>
[16:16:22]: ▸ 0x00000003 <uint32>=0x00000001
[16:16:23]: ▸ 0x00000004 <uint32>=0x00000000
[16:16:23]: ▸ 0x00000005 <uint32>=0x00000000
[16:16:23]: ▸ 0x00000006 <blob>=0xDA1AC06D8CDEE0CF958E0AE7D6AA045A22DECA6F "\332\032\300m\214\336\340\317\225\216\012\347\326\252\004Z"\336\312o"
[16:16:23]: ▸ 0x00000007 <blob>=<NULL>
[16:16:23]: ▸ 0x00000008 <blob>=0x7B38373139316361322D306663392D313164342D383439612D3030303530326235323132327D00 "{87191ca2-0fc9-11d4-849a-000502b52122}\000"
[16:16:23]: ▸ 0x00000009 <uint32>=0x0000002A "\000\000\000*"
[16:16:23]: ▸ 0x0000000A <uint32>=0x00000800
[16:16:23]: ▸ 0x0000000B <uint32>=0x00000800
[16:16:23]: ▸ 0x0000000C <blob>=0x0000000000000000
[16:16:23]: ▸ 0x0000000D <blob>=0x0000000000000000
[16:16:23]: ▸ 0x0000000E <uint32>=0x00000001
[16:16:23]: ▸ 0x0000000F <uint32>=0x00000001
[16:16:23]: ��� 0x00000010 <uint32>=0x00000001
[16:16:23]: ▸ 0x00000011 <uint32>=0x00000000
[16:16:23]: ▸ 0x00000012 <uint32>=0x00000001
[16:16:23]: ▸ 0x00000013 <uint32>=0x00000001
[16:16:23]: ▸ 0x00000014 <uint32>=0x00000001
[16:16:23]: ▸ 0x00000015 <uint32>=0x00000001
[16:16:23]: ▸ 0x00000016 <uint32>=0x00000001
[16:16:23]: ▸ 0x00000017 <uint32>=0x00000001
[16:16:23]: ▸ 0x00000018 <uint32>=0x00000001
[16:16:23]: ▸ 0x00000019 <uint32>=0x00000001
[16:16:23]: ▸ 0x0000001A <uint32>=0x00000001
[16:16:23]: -----------------
[16:16:23]: --- Step: gym ---
[16:16:23]: -----------------
<<<<<<<skipped>>>>>>>>
[16:43:48]: ▸ Touching Project.app
[16:44:34]: ▸ Signing /Users/travis/Library/Developer/Xcode/DerivedData/Project-dtaoyjhgdxdnqsdrizcxetkzcack/Build/Intermediates/ArchiveIntermediates/Release/InstallationBuildProductsLocation/Applications/Project.app
[16:45:01]: ▸ Touching Project.app.dSYM
[16:45:36]: ▸ Archive Succeeded
[16:45:41]: Generated plist file with the following values:
[16:45:41]: ▸ -----------------------------------------
[16:45:41]: ▸ {
[16:45:41]: ▸ "provisioningProfiles": {
[16:45:41]: ▸ "[secure]": "match Development [secure]"
[16:45:41]: ▸ },
[16:45:41]: ▸ "method": "app-store"
[16:45:41]: ▸ }
[16:45:41]: ▸ -----------------------------------------
RVM detected, forcing to use system ruby
Warning! PATH is not properly set up, '/Users/travis/.rvm/gems/ruby-2.0.0-p648/bin' is not at first place,
usually this is caused by shell initialization files - check them for 'PATH=...' entries,
it might also help to re-add RVM to your dotfiles: 'rvm get stable --auto-dotfiles',
to fix temporarily in this shell session run: 'rvm use ruby-2.0.0-p648'.
Now using system ruby.
+xcodebuild -exportArchive -exportOptionsPlist /var/folders/bb/n7t3rs157850byt_jfdcq9k80000gn/T/gym_config20170717-6999-136gqmg.plist -archivePath '/Users/travis/Library/Developer/Xcode/Archives/2017-07-17/Project 2017-07-17 16.16.38.xcarchive' -exportPath /var/folders/bb/n7t3rs157850byt_jfdcq9k80000gn/T/gym_output20170717-6999-e3euz4
2017-07-17 16:45:50.712 xcodebuild[11451:26101] [MT] IDEDistribution: -[IDEDistributionLogging _createLoggingBundleAtPath:]: Created bundle at path '/var/folders/bb/n7t3rs157850byt_jfdcq9k80000gn/T/Release_2017-07-17_16-45-50.706.xcdistributionlogs'.
2017-07-17 16:45:56.703 xcodebuild[11451:26101] [MT] IDEDistribution: Step failed: <IDEDistributionSigningAssetsStep: 0x7f8fc5c9e9f0>: Error Domain=IDEDistributionErrorDomain Code=1 "No valid iOS Distribution signing identities belonging to team [secure] were found." UserInfo={NSLocalizedDescription=No valid iOS Distribution signing identities belonging to team [secure] were found.}
error: exportArchive: No valid iOS Distribution signing identities belonging to team [secure] were found.
Error Domain=IDEDistributionErrorDomain Code=1 "No valid iOS Distribution signing identities belonging to team [secure] were found." UserInfo={NSLocalizedDescription=No valid iOS Distribution signing identities belonging to team [secure] were found.}
** EXPORT FAILED **
+shell_session_update
/Users/travis/build/[secure]/iOS/vendor/bundle/ruby/2.3.0/gems/fastlane-2.47.0/gym/lib/assets/wrap_xcodebuild/xcbuild-safe.sh: line 62: shell_session_update: command not found
[16:45:56]: Exit status: 70
+---------------+-------------------------+
| Build environment |
+---------------+-------------------------+
| xcode_path | /Applications/Xcode.app |
| gym_version | 2.47.0 |
| export_method | app-store |
| sdk | iPhoneOS10.2.sdk |
+---------------+-------------------------+
[16:45:57]: ▸ cd /Users/travis/build/[secure]/iOS/Project
[16:45:57]: ▸ export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/Users/travis/build/[secure]/iOS/vendor/bundle/ruby/2.3.0/bin:/Users/travis/.rvm/gems/ruby-2.3.1/bin:/Users/travis/.rvm/gems/ruby-2.3.1@global/bin:/Users/travis/.rvm/rubies/ruby-2.3.1/bin:/Users/travis/.rvm/bin:/Users/travis/bin:/Users/travis/.local/bin:/Users/travis/.nvm/versions/node/v6.9.1/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin"
[16:45:57]: ▸ /usr/bin/touch -c /Users/travis/Library/Developer/Xcode/DerivedData/Project-dtaoyjhgdxdnqsdrizcxetkzcack/Build/Intermediates/ArchiveIntermediates/Release/BuildProductsPath/Release-iphoneos/Project.app.dSYM
[16:45:57]: ▸ ** ARCHIVE SUCCEEDED **
[16:45:57]:
[16:45:57]: ⬆️ Check out the few lines of raw `xcodebuild` output above for potential hints on how to solve this error
[16:45:57]: 📋 For the complete and more detailed error log, check the full log at:
[16:45:57]: 📋 /Users/travis/Library/Logs/gym/Project-Release.log
[16:45:57]:
[16:45:57]: There is a mismatch between your provided `export_method` in gym
[16:45:57]: and the selected provisioning profiles. You passed the following options:
[16:45:57]: export_method: app-store
[16:45:57]: Bundle identifier: [secure]
[16:45:57]: Profile name: match Development [secure]
[16:45:57]: Profile type: development
[16:45:57]: Make sure to either change the `export_method` passed from your Fastfile or CLI
[16:45:57]: or select the correct provisioning profiles by updating your Xcode project
[16:45:57]: or passing the profiles to use by using match or manually via the `export_options` hash
[16:45:57]:
[16:45:57]:
[16:45:57]: Looks like fastlane ran into a build/archive error with your project
[16:45:57]: It's hard to tell what's causing the error, so we wrote some guides on how
[16:45:57]: to troubleshoot build and signing issues: https://docs.fastlane.tools/codesigning/getting-started/
[16:45:57]: Before submitting an issue on GitHub, please follow the guide above and make
[16:45:57]: sure your project is set up correctly.
[16:45:57]: fastlane uses `xcodebuild` commands to generate your binary, you can see the
[16:45:57]: the full commands printed out in yellow in the above log.
[16:45:57]: Make sure to inspect the output above, as usually you'll find more error information there
[16:45:57]:
Environment
Please run fastlane env and copy the output below. This will help us help you 👍
If you used --capture_output option please remove this block - as it is already included there.
16:45:58: — Step: fastlane env —
16:45:58: --------------------------
16:45:58: $ fastlane env
[16:46:07]: ▸ [16:46:07]: Generating fastlane environment output, this might take a few seconds…
[16:46:08]: ▸ ✅ fastlane environment ✅
[16:46:08]: ▸ ### Stack
[16:46:08]: ▸ | Key | Value |
[16:46:08]: ▸ | --------------------------- | ---------------------------------------------------------- |
[16:46:08]: ▸ | OS | 10.12.1 |
[16:46:08]: ▸ | Ruby | 2.3.1 |
[16:46:08]: ▸ | Bundler? | true |
[16:46:08]: ▸ | Git | git version 2.11.0 |
[16:46:08]: ▸ | Installation Source | ~/build/[secure]/iOS/vendor/bundle/ruby/2.3.0/bin/fastlane |
[16:46:08]: ▸ | Host | Mac OS X 10.12.1 (16B2555) |
[16:46:08]: ▸ | Ruby Lib Dir | ~/.rvm/rubies/ruby-2.3.1/lib |
[16:46:08]: ▸ | OpenSSL Version | OpenSSL 1.0.2j 26 Sep 2016 |
[16:46:08]: ▸ | Is contained | false |
[16:46:08]: ▸ | Is homebrew | false |
[16:46:08]: ▸ | Is installed via Fabric.app | false |
[16:46:08]: ▸ | Xcode Path | /Applications/Xcode.app/Contents/Developer/ |
[16:46:08]: ▸ | Xcode Version | 8.2 |
[16:46:08]: ▸ ### System Locale
[16:46:08]: ▸ | Variable | Value | |
[16:46:08]: ▸ | -------- | ----------- | - |
[16:46:08]: ▸ | LANG | en_US.UTF-8 | ✅ |
[16:46:08]: ▸ | LC_ALL | en_US.UTF-8 | ✅ |
[16:46:08]: ▸ | LANGUAGE | | |
[16:46:09]: ▸ ### fastlane gems
[16:46:09]: ▸ | Gem | Version | Update-Status |
[16:46:09]: ▸ | -------- | ------- | ------------- |
[16:46:09]: ▸ | fastlane | 2.47.0 | ✅ Up-To-Date |
[16:46:09]: ▸ ### Loaded fastlane plugins:
[16:46:09]: ▸ No plugins Loaded
[16:46:09]: ▸ Loaded gems
[16:46:09]: ▸ | Gem | Version |
[16:46:09]: ▸ | ------------------------- | ------------ |
[16:46:09]: ▸ | io-console | 0.4.5 |
[16:46:09]: ▸ | CFPropertyList | 2.3.5 |
[16:46:09]: ▸ | public_suffix | 2.0.5 |
[16:46:09]: ▸ | addressable | 2.5.1 |
[16:46:09]: ▸ | babosa | 1.0.2 |
[16:46:09]: ▸ | bundler | 1.15.1 |
[16:46:09]: ▸ | colored | 1.2 |
[16:46:09]: ▸ | highline | 1.7.8 |
[16:46:09]: ▸ | commander-fastlane | 4.4.5 |
[16:46:09]: ▸ | dotenv | 2.2.1 |
[16:46:09]: ▸ | excon | 0.57.1 |
[16:46:09]: ▸ | multipart-post | 2.0.0 |
[16:46:09]: ▸ | faraday | 0.12.1 |
[16:46:09]: ▸ | unf_ext | 0.0.7.4 |
[16:46:09]: ▸ | unf | 0.1.4 |
[16:46:09]: ▸ | domain_name | 0.5.20170404 |
[16:46:09]: ▸ | http-cookie | 1.0.3 |
[16:46:09]: ▸ | faraday-cookie_jar | 0.0.6 |
[16:46:09]: ��� | faraday_middleware | 0.11.0.1 |
[16:46:09]: ▸ | fastimage | 2.1.0 |
[16:46:09]: ▸ | gh_inspector | 1.0.3 |
[16:46:09]: ▸ | jwt | 1.5.6 |
[16:46:09]: ▸ | little-plugger | 1.1.4 |
[16:46:09]: ▸ | multi_json | 1.12.1 |
[16:46:09]: ▸ | logging | 2.2.2 |
[16:46:09]: ▸ | memoist | 0.16.0 |
[16:46:09]: ▸ | os | 0.9.6 |
[16:46:09]: ▸ | signet | 0.7.3 |
[16:46:09]: ▸ | googleauth | 0.5.1 |
[16:46:09]: ▸ | httpclient | 2.8.3 |
[16:46:09]: ▸ | mime-types-data | 3.2016.0521 |
[16:46:09]: ▸ | mime-types | 3.1 |
[16:46:09]: ▸ | declarative | 0.0.9 |
[16:46:09]: ▸ | declarative-option | 0.1.0 |
[16:46:09]: ▸ | uber | 0.1.0 |
[16:46:09]: ▸ | representable | 3.0.4 |
[16:46:09]: ▸ | retriable | 3.0.2 |
[16:46:09]: ▸ | google-api-client | 0.12.0 |
[16:46:09]: ▸ | json | 2.1.0 |
[16:46:09]: ▸ | mini_magick | 4.5.1 |
[16:46:09]: ▸ | multi_xml | 0.6.0 |
[16:46:09]: ▸ | plist | 3.3.0 |
[16:46:09]: ▸ | rubyzip | 1.2.1 |
[16:46:09]: ▸ | security | 0.1.3 |
[16:46:09]: ▸ | slack-notifier | 1.5.1 |
[16:46:09]: ▸ | terminal-notifier | 1.8.0 |
[16:46:09]: ▸ | unicode-display_width | 1.3.0 |
[16:46:09]: ▸ | terminal-table | 1.8.0 |
[16:46:09]: ▸ | tty-screen | 0.5.0 |
[16:46:09]: ▸ | word_wrap | 1.0.0 |
[16:46:09]: ▸ | claide | 1.0.2 |
[16:46:09]: ▸ | colored2 | 3.1.2 |
[16:46:09]: ▸ | nanaimo | 0.2.3 |
[16:46:09]: ▸ | xcodeproj | 1.5.0 |
[16:46:09]: ▸ | rouge | 2.0.7 |
[16:46:09]: ▸ | xcpretty | 0.2.8 |
[16:46:09]: ▸ | xcpretty-travis-formatter | 0.0.4 |
[16:46:09]: ▸ | i18n | 0.8.6 |
[16:46:09]: ▸ | minitest | 5.10.2 |
[16:46:09]: ▸ | thread_safe | 0.3.6 |
[16:46:09]: ▸ | tzinfo | 1.2.3 |
[16:46:09]: ▸ | activesupport | 4.2.9 |
[16:46:09]: ▸ | mustache | 0.99.8 |
[16:46:09]: ▸ | mini_portile2 | 2.2.0 |
[16:46:09]: ▸ | nokogiri | 1.8.0 |
[16:46:09]: ▸ | redcarpet | 3.4.0 |
[16:46:09]: ▸ | rb-fsevent | 0.10.2 |
[16:46:09]: ▸ | ffi | 1.9.18 |
[16:46:09]: ▸ | rb-inotify | 0.9.10 |
[16:46:09]: ▸ | sass-listen | 4.0.0 |
[16:46:09]: ▸ | sass | 3.5.1 |
[16:46:09]: ▸ | jazzy | 0.0.14 |
[16:46:09]: ▸
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Comments: 25 (3 by maintainers)
Hey everyone, really sorry for the troubles, this was totally my fault. We introduced this change as part of https://github.com/fastlane/fastlane/commit/e11dda6e18a64536446adbad665ff7409d786f51#diff-22016844968254d7333ffbaddd66a85eL12, however we didn’t expect to introduce any changes to any of the existing setups.
Basically until now we set the
export_methodtodevelopmentif your last match run was adevelopmentrun. This introduced a problem for many setups that don’t want to use gym for development, but just want to distribute to the App Store.We decided it’s better never to default to
development, as this is an edge case, as most people want to distribute either to App Store, Ad Hoc or Enterprise.Please update your
Fastfileto use the followingexport_methodflag:or, if you prefer, you can add the following to your
Gymfile:Sorry for introducing this regression for your setups, but we do want this to be the new default, as it will save lots of people a lot of time in the future 👍
Thanks everyone, we just pushed https://github.com/fastlane/fastlane/pull/9863, which should be part of the next release, later today 👍
A reminder: this is just showing the wrong information on how to fix the issue, this will not fix your build errors, which are mostly unrelated to code signing, but your project, more information in my last comment
@KrauseFx thanks for your explanation. it make sense, although i would say that actually we use fast lane more often for nightly builds and CI, so my argument would be that app-store build is less often used as others especially with tools like hockey app and fabric beta.
export_methodparam is optional but the default valueapp-storemight not be valid with the scheme you are using, so you will have to specify this value