fastlane: fastlane deliver: Potential server error received: 'Unexpected Error'

Update 5

There were some issues reported in the PR and I’m working on taking care of them! I will probably not end up getting everything finished today 😔 I’ve worked about 15 hours on this and my brain is starting to get a bit loopy 🙃

I’ll be waking up early tomorrow to continue where I leave off tonight. I’m feeling pretty confident that I should be able to release a new version tomorrow (with some follow up versions with any other issues that pop up).

Thank you to all of you for the patience! I really appreciate it 😊 ❤️

+230

joshdholtz on Jun 18, 2020

👋 I’m making progress on things here. I have almost all of the API endpoints figured out and will soon be integrating them into tools like deliver

I would appreciate if there were no more “+1” comments or anything that doesn’t provide value into helping me solve this issue 😇

I would like it easy for new people coming to this issue to find the actual status of things.

Original comment from me about what’s happening - https://github.com/fastlane/fastlane/issues/16621#issuecomment-645301517

I will add more comments and a link to a PR when I have progress I can share 💪

EDIT: I will hide comments that I don’t think provide value and are just spam 😉

+91

Update 7

Giving you all another update before go to bed 😊

Made pretty good progress today. Spent most of the morning and afternoon working with issues of users testing out the PR. This evening was finishing up missing meta data information. Lost quite a bit of time to IDFA and app category endpoints.

Below is a checklist I’ve made on the PR 👇 Tomorrow is going to be testing screenshots on things that aren’t iOS and wrangling the broken tests 😇

Screen Shot 2020-06-18 at 11 59 53 PM

If anybody else could test out that PR tomorrow that would be great!

Thanks again for all the help and being patient ❤️

+87

Update 1

I’ve successfully completed the following with new API endpoints:

List App Store versions
List App Store version localizations
Create new App Store version localization
Delete App Store version localization
List screenshots by display type
Upload new screenshots
Delete screenshots

Thing I (might) need to do still

Create new App Store version
List previews (videos)
Upload previews
Delete previews)

Now that I’ve gotten most of the new API endpoints and models implemented, I will be starting to rip out all usage of Spaceship::Tunes from deliver in favor of my new Spaceship::ConnectAPI::Tunes module.

I will probably discover some new endpoints that I need to implement but this is light at the end of the tunnel.

I will create a PR once I have a working deliver with screenshots, previews, and metadata. ⚠️ This PR will be available for you all to test but I won’t guarantee there won’t be some issues right away 😉 I will still need to write a bunch of tests for all the changes.

+75

Update 2

🥳 I got screenshots uploading through deliver with the new App Store Connect API endpoints

Next steps

Check (and fix) creating new version of app
Check (and fix) metadata
Check (and fix) submission
Check (and fix) app previews/videos

I will get a PR pushed once I can verify that creating new app version and uploading meta data either still works or works again 💪

+66

@joshdholtz , Thanks your hard work, Man, You’re my hero.

+65

cuongtv51 on Jun 18, 2020

Please don’t comment +1, peeps. That’s why the 👍 emoji exists for.

+65

freak4pc on Jun 17, 2020

Question

👋 Hey, fam! I have never used app previews for any of my apps so I just noticed that deliver does not actually support uploading app previews 😔

Would this be a feature you would like me to add in a follow up PR? 👍 reaction for “yes” 👀 reaction for “I’d use if I needed it” 👎 reaction for “seems like overkill”

Perfect! Glad I didn’t add it in yet 😊

+60

@crazymanish I’m working as hard as I can on a fix now to adapt to new API endpoints that are available.

+58

Can I just say your dedication to getting this fixed so fast in a highly pressured week before WWDC is just incredible. Thank you.

+51

alexcroox on Jun 19, 2020

Update 10

👋 Hey, fam! I merged in #16626, created the 2.150.0.rc1 release, and pushed the gem out to Ruby gems.

You can install it by 👇

gem "fastlane", ">= 2.150.0.rc1"

I will be working on cleaning feature up, adding tests, and responding/fixing any issues that come in. I’m hoping to get an official 2.150.0 release out end of next week 🤞

🙏 Please make new issues for anything that you see in 2.150.0.rc1. It is easier to have conversations and work through issues that way 😊

⚠️ I will most likely be locking this issue tomorrow sometime to prevent any other issues from getting added into this one 😊

❓ Please feel free to create new issues and mention me if you if have any questions or concerns. You can also tweet/DM me at @joshdholtz for any questions.

Thanks again for all the help in testing this out!

New issue template for release candidate

Use this for creating new any issues with the release candidate 👇 Screen Shot 2020-06-20 at 7 00 58 PM

PR/branch for 2.150.0 release candidate

I will be adding a few more features, code cleanup, and tests into this branch before it gets officially released 👇 https://github.com/fastlane/fastlane/pull/16640

Issue for release candidate

I created a pinned issue explaining how to use the release candidate 👇 https://github.com/fastlane/fastlane/issues/16639

+46

joshdholtz on Jun 21, 2020

Update 3

There are A LOT of metadata APIs to hit. Hoping to have PR up in an hour-ish.

EDIT: That was fast hour… I need a bit more time 😇

+42

Hey @joshdholtz, looking forward to the new release 😄 I just wanted to say thanks for your hard work and your real time updates today! Thanks for saving our asses man!

+39

rserentill on Jun 17, 2020

+1 Must have something to do with the AppStoreConnect refresh. It’s funny because my immediate reaction upon seeing the new interface was, ‘Okay but will this break fastlane???’

+32

ThrowJojo on Jun 17, 2020

Update 4

My PR is “ready” 😛 - https://github.com/fastlane/fastlane/pull/16626

Things working

App screenshots
App metadata
- Version metadata
- Localized version metadata
- Review detail
- Review attachment
- Version phased release
- Reset rating request

Things not working yet

App preview
App metadata
- App rating
- Trade representative information
Submitting correct version

Any field testing would be appreciated 🙏

Update Gemfile to below 👇
Run bundle install, bundle update, or bundle update fastlane

gem "fastlane", :git => "https://github.com/fastlane/fastlane.git", :branch => "joshdholtz-update-deliver-for-app-store-connect-api"

Please leave any comment about this PR in the PR 😊

Its been about 10 hours so I need to take a little break 😇 I’ll be continuing to work on this tonight to get it merged and released as soon as possible.

+31

@csv8674xn For sure! I will pump out a release as soon as I click the merge button.

I have quite a bit more new feature/fixes work yet and then updating all of the tests 😀 I will try to get it all done tonight 🤞

+29

Uploading binaries seem to work well. This error caused by uploading metadata and assets.

For current workaround, we can skip to upload metadata and screenshots. However, there is no efficient way to skip upload assets…

upload_to_app_store(
  skip_metadata: true,
  skip_screenshots: true,
  metadata_path: nil
)

+23

giginet on Jun 17, 2020

Update 9

👋 We are SOOOOOO close! Everything is feeling pretty good on the PR. I’m going to go for a health walk to clear mind and see if anything else pops in to my head that I missed.

The release candidate should be out in a few hours 🚀 I’ll update more info here later on how to use.

Thanks, all! ❤️

+21

@rogerluan Thanks for the info! I just wrote the new code to handle this about 30 minutes ago in deliver so we should be good once fastlane is fixed 😊

+21

Update 6

We made lots of progress on the PR! Only a few things left I think 😊

Also…

ERROR ITMS-90382: "Upload limit reached. The upload limit for your application has been reached. Please wait 1 day and try again."

I hit my binary upload limit and need to wait 24 hours 🤷‍♂️

EDIT: Turn out ERROR ITMS-90382: is only app based (not account based). Chugging along on another app on my account 😇

+20

joshdholtz on Jun 18, 2020

@alekzernov I’m working on a fix now. Please see https://github.com/fastlane/fastlane/issues/16621#issuecomment-645301517 😊

Using the App Store Connect website is a solution if you need to upload new screenshots in the mean time 😉

+20

Best josh in this world

+15

freak4pc on Jun 17, 2020

Today we have hotfix release & our release pipeline is broken 😱😤 Now Skipping metadata & screenshots…trying again 🤞🏻

Update:

Skipping metadata & screenshots did not work with deliver…
Pilot is working…so at least we don’t need to upload binary manually ❤️

+12

crazymanish on Jun 18, 2020

Heads up

At Tellus, all our iOS releases are manual, and iTunes Connect would remember this setting from the last app version. Unfortunately, that wasn’t the case now with this iTunes Connect revamp! The option went back to the Automatically release this version default 👎 luckily, I caught this in time.

Check your apps, make sure you update this setting correctly.

+11

rogerluan on Jun 17, 2020

Update 8

Good <time of day wherever you all are>! We have decided that we are going to release PR #16626 as a release candidate build soon™️ (mid-day tomorrow Chicago time).

Making of candidate `2.150.0.rc1`

We are going to forgo writing new tests for deliver in PR #16626 I want to get this build out as soon as I can and there are a lot of tests that need to be written. We will then release a new version as 2.150.0.rc1.

Plan after `2.150.rc1`

Create new temporary issue template specifically for reporting issues on deliver and release candidate
Monitor issues closely for any with deliver or spaceship
Make fixes quickly and release new release candidates as fix is merged in
Open new PR for updating deliver tests

Any thoughts, questions, or concerns are appreciated! 😊

+10

Hey @joshdholtz, we’ve successfully submitted an app using this branch 🎉 Thanks for the hard work!

EDIT Everything was fine except it wasn’t automatically submitted for review, even though it was set up to do it. I was able to submit it for review with one click in the App store connect.

Here’s the deliver summary for the reference:

+--------------------------------------+--------------------------------------+
|                           deliver 2.149.1 Summary                           |
+--------------------------------------+--------------------------------------+
| force                                | true                                 |
| team_id                              | *********                            |
| team_name                            | *********                            |
| itc_provider                         | *********                            |
| username                             | *********                            |
| app_identifier                       | *********                            |
| skip_screenshots                     | false                                |
| skip_metadata                        | false                                |
| submit_for_review                    | true                                 |
| automatic_release                    | true                                 |
| price_tier                           | 0                                    |
| app_icon                             | app-store-icon.png                   |
| copyright                            | *********                            |
| primary_category                     | Business                             |
| description.en-US                    | *********                            |
| keywords.en-US                       | *********                            |
| release_notes.en-US                  | *********                            |
| privacy_url.en-US                    | *********                            |
| marketing_url.en-US                  | *********                            |
| support_url.en-US                    | *********                            |
| submission_information.add_id_info_  | false                                |
| uses_idfa                            |                                      |
| submission_information.add_id_info_  | false                                |
| serves_ads                           |                                      |
| submission_information.add_id_info_  | false                                |
| tracks_action                        |                                      |
| submission_information.add_id_info_  | false                                |
| tracks_install                       |                                      |
| submission_information.content_righ  | true                                 |
| ts_has_rights                        |                                      |
| submission_information.content_righ  | true                                 |
| ts_contains_third_party_content      |                                      |
| submission_information.export_compl  | ios                                  |
| iance_platform                       |                                      |
| submission_information.export_compl  | false                                |
| iance_compliance_required            |                                      |
| submission_information.export_compl  | false                                |
| iance_encryption_updated             |                                      |
| submission_information.export_compl  | true                                 |
| iance_uses_encryption                |                                      |
| submission_information.export_compl  | true                                 |
| iance_is_exempt                      |                                      |
| submission_information.export_compl  | false                                |
| iance_contains_third_party_cryptogr  |                                      |
| aphy                                 |                                      |
| submission_information.export_compl  | false                                |
| iance_contains_proprietary_cryptogr  |                                      |
| aphy                                 |                                      |
| submission_information.export_compl  | false                                |
| iance_available_on_french_store      |                                      |
| app_review_information.first_name    | *********                            |
| app_review_information.last_name     | *********                            |
| app_review_information.phone_number  | *********                            |
| app_review_information.email_addres  | *********                            |
| s                                    |                                      |
| app_review_information.demo_user     | *********                            |
| app_review_information.demo_passwor  | *********                            |
| d                                    |                                      |
| overwrite_screenshots                | true                                 |
| run_precheck_before_submit           | false                                |
| app_rating_config_path               | ./fastlane/ratings.json              |
| ipa                                  | *********                            |
| screenshots_path                     | ./fastlane/screenshots               |
| metadata_path                        | ./fastlane/metadata                  |
| app_version                          | *********                            |
| platform                             | ios                                  |
| edit_live                            | false                                |
| use_live_version                     | false                                |
| skip_binary_upload                   | false                                |
| skip_app_version_update              | false                                |
| reject_if_possible                   | false                                |
| phased_release                       | false                                |
| reset_ratings                        | false                                |
| precheck_default_rule_level          | warn                                 |
| individual_metadata_items            | []                                   |
| ignore_language_directory_validatio  | false                                |
| n                                    |                                      |
| precheck_include_in_app_purchases    | true                                 |
+--------------------------------------+--------------------------------------+

+10

mjovkovic on Jun 19, 2020

@mjovkovic Submit for review is fixed now! I had one line commented out during my testing 😇 Thanks for testing!

@Mike278 Thanks for the report! I will also look into this too while I’m in deliver 👍

Yeap happens after the new Appstore Connect updates

Potential server error received: 'Unexpected Error'. Retrying after 10 seconds (remaining: 2)...
Potential server error received: 'Unexpected Error'. Retrying after 10 seconds (remaining: 1)...

markwongsoontorn on Jun 17, 2020

@starostin That is perfect! Thank you so much ❤️ I will have a new commit ready in 5 to 10 minutes for you 😊

@Aw79 Glad it works! And I appreciate the offer but you don’t need to do that 😊

For me, @giginet’s upload_to_app_store snippet above still resulted in an Unexpected Error. However, using upload_to_testflight worked for uploading the binary.

TheLartians on Jun 17, 2020

@joshdholtz The log for the first api call is huge, and I cant send you the whole response, but I found on it the mention of metadata
"versionString"=>"1.6.3", "appStoreState"=>"METADATA_REJECTED", Is it something that can help?

starostin on Jun 20, 2020

@joshdholtz just tried your branch to update the app’s metadata (not screenshot, no binary) and it worked well, apart from the fact that it removed the Primary Category from the general app information (which was Travel).

arne-dott on Jun 19, 2020

Thanks for working on this Josh! I have 100 apps to update in a few days and this stopped everything cold. Anxiously waiting!

tymcdowell on Jun 18, 2020

produce

INFO [2020-06-17 10:30:36.60]: Creating new app 'xxx' on App Store Connect
INFO [2020-06-17 10:30:42.85]: Ensuring version number
Potential server error received: 'Unexpected Error'. Retrying after 10 seconds (remaining: 2)...
Potential server error received: 'Unexpected Error'. Retrying after 10 seconds (remaining: 1)...

deliver

INFO [2020-06-17 09:00:09.35]: Making sure the latest version on App Store Connect matches '1.26' from the ipa file...
Potential server error received: 'Unexpected Error'. Retrying after 10 seconds (remaining: 2)...
Potential server error received: 'Unexpected Error'. Retrying after 10 seconds (remaining: 1)...

AmauriC on Jun 17, 2020

OrtizLin on Jun 17, 2020

There was a big new appstoreconnect update today - I can’t tell if that’s relevant, but it definitely falls under suspicious.

jtruher on Jun 17, 2020

Still getting the problem, here’s a snippet from my bitrise log.
�[32m2.150.0.rc1�[0m
- [deliver][produce][spaceship] Update to use new App Store Connect API endpoints (#16626) via @joshdholtz
## Instructions on testing the release candidate
### Bundler
Update your `Gemfile` to include the following:
```rb
gem "fastlane", ">= 2.150.rc1"
At the bottom of the log file the error is displayed, included below:

Potential server error received: 'Unexpected Error'. Retrying after 10 seconds (remaining: 2)...

I think your Fastlane is not really updated. Just try to verify your Fastlane version again

dungtran-groove on Jun 22, 2020

@joshdholtz - Thanks. I found that and I am adding it now. I only told you because I never got this before.

natedenh on Jun 21, 2020

@joshdholtz

Hello there This problem is often found during uploading screenshots [!] The request could not be completed because: Server error got 504 Don’t know how to fix it?

shizu2014 on Jun 21, 2020

RC worked for me, thank you so much @joshdholtz! ❤️

Edit: I just suddenly had to add the usesIdfa property (our app doesn’t use it) to my deliver config, as per https://docs.fastlane.tools/actions/appstore/#compliance-and-idfa-settings.

TheWirv on Jun 21, 2020

@tymcdowell Fixed that about 16 minutes ago 😇 https://github.com/fastlane/fastlane/pull/16626/commits/3a46a0031ca6866854f32d9ee7e3bbab5ffbdcbf

Everything is working except that it is not updating the age ratings.

tymcdowell on Jun 20, 2020

@joshdholtz It works 🥳🥳🥳 Thanks a lot !!!

starostin on Jun 20, 2020

@starostin Ha, not a problem! 😊 I have plenty of other things I’m still working on 🤷‍♂️

I really appreciate you taking the time to help me test! ❤️

@starostin Ahhhh! I will have a new commit that should fix things for you in like 5 minutes 😊

@romandutov Hey! Your stacktrace shows an error from the latest release of fastlane (which is known to be broken). If you switch to the branch of the PR that fixes this issue you would probably be okay 🙂 I will be releasing a new release candidate version tomorrow that will fix things for a lot of users 💪

@tmaly1980 Great question! I will updated my post with that 😊 I’m putting a bunch of things together tonight yet and then need to one last round of testing. Will probably be tomorrow last morning / early afternoon Chicago time 🤞

@arne-dott Ah, my apologies! The new API changed the category keys so I had to map them the old ones to the new ones but might have missed travel 😩 What value were you using? Was it just “Travel”?